Date: Wed, 3 Jun 1998 08:20:01 -0700 (PDT) From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> To: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/6837: in_setpeeraddr() and in_setsockaddr() block on memory Message-ID: <199806031520.IAA18818@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/6837; it has been noted by GNATS. From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> To: dg@root.com Cc: Craig Metz <cmetz@inner.net>, freebsd-gnats-submit@FreeBSD.ORG Subject: Re: kern/6837: in_setpeeraddr() and in_setsockaddr() block on memory Date: Wed, 3 Jun 1998 11:16:13 -0400 (EDT) <<On Wed, 03 Jun 1998 05:11:02 -0700, David Greenman <dg@root.com> said: > I believe this was a side effect of the elimination of using mbufs as > containers for sockaddr data. I don't see a problem with changing the caller > to malloc(), but perhaps Garrett might have a thought on this since he was > the one to add the MALLOC there in the first place. Garrett? Well, Bruce noted that doing all the copying slows things down somewhat. I was planning on reworking the interface Yet Again to make the setsockaddr/setpeeraddr interface take a struct uio and then copy the answer directly to its intended location. (Probably do the same thing for the other calls that pass out a sockaddr, and make a generic interface that encapsulates the desired error behavior.) -GAWollman -- Garrett A. Wollman | O Siem / We are all family / O Siem / We're all the same wollman@lcs.mit.edu | O Siem / The fires of freedom Opinions not those of| Dance in the burning flame MIT, LCS, CRS, or NSA| - Susan Aglukark and Chad Irschick To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806031520.IAA18818>