Date: Tue, 29 Dec 2020 17:48:25 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Kyle Evans <kevans@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: ee938b20335d - main - kern: efirt: correct configuration table entry size Message-ID: <E4CC4F44-F314-4D53-BC87-747A756323D9@freebsd.org> In-Reply-To: <202012291739.0BTHd2ji001052@gitrepo.freebsd.org> References: <202012291739.0BTHd2ji001052@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29 Dec 2020, at 17:39, Kyle Evans <kevans@FreeBSD.org> wrote:
> diff --git a/sys/sys/efi.h b/sys/sys/efi.h
> index b9f31454efff..220509853cb2 100644
> --- a/sys/sys/efi.h
> +++ b/sys/sys/efi.h
> @@ -52,7 +52,7 @@ typedef unsigned long efi_status;
>
> struct efi_cfgtbl {
> struct uuid ct_uuid;
> - uint64_t ct_data;
> + void *ct_data;
Hm, this should probably be a u_long/vm_offset_t/vm_paddr_t (though the
tables are unlikely to be in places where you need PAE so even if
technically correct, vm_paddr_t probably just makes things more awkward
for no gain) given it's not a real pointer that can be dereferenced.
Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E4CC4F44-F314-4D53-BC87-747A756323D9>