Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Jul 2008 05:12:08 +1000
From:      Peter Jeremy <peterjeremy@optushome.com.au>
To:        Pyun YongHyeon <yongari@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/conf NOTES files src/sys/modules Makefile src/sys/modules/jme Makefile
Message-ID:  <20080728191208.GA40936@server.vk2pj.dyndns.org>
In-Reply-To: <200805270154.m4R1sjAn023638@repoman.freebsd.org>
References:  <200805270154.m4R1sjAn023638@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--wRRV7LY7NUeQGEoC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

[A bit late but I only just noticed]
On 2008-May-27 01:54:45 +0000, Pyun YongHyeon <yongari@freebsd.org> wrote:
>yongari     2008-05-27 01:54:45 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/conf             NOTES files=20
>    sys/modules          Makefile=20
>  Added files:
>    sys/modules/jme      Makefile=20
>  Log:
>  Hook up jme(4) to the build.
> =20
>  Revision  Changes    Path
>  1.1492    +1 -0      src/sys/conf/NOTES
=2E..

Whilst you have included a comment about jme(4) in NOTES, there is no
associated 'device jme' line.  All other NIC drivers have both a comment
line and an actual device line apart from msk(4) and stge(4) (both of
which you also committed).

This bug has been carried through in your MFCs.

Could you please update NOTES to include both lines for all three devices
in all relevant branches so ensure that LINT builds include these devices.

--=20
Peter Jeremy
Please excuse any delays as the result of my ISP's inability to implement
an MTA that is either RFC2821-compliant or matches their claimed behaviour.

--wRRV7LY7NUeQGEoC
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEARECAAYFAkiOGggACgkQ/opHv/APuIf4YQCfW5G/NeHbsKh7Zm+eOqC81N5N
4OYAn3FSfmx9RVxrk2h30OyNspvoauFj
=2zMW
-----END PGP SIGNATURE-----

--wRRV7LY7NUeQGEoC--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080728191208.GA40936>