Date: Fri, 13 Jan 2017 03:56:12 +0100 From: "Carlos J. Puga Medina" <cpm@FreeBSD.org> To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r431337 - head/www/chromium Message-ID: <1484276172.95107.4.camel@FreeBSD.org> In-Reply-To: <454077ca-b6ce-966f-2b83-17d3ac68b40b@marino.st> References: <201701130236.v0D2a8fN001308@repo.freebsd.org> <454077ca-b6ce-966f-2b83-17d3ac68b40b@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-AR6Xl0896djhAzAnMHGa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-01-12 at 20:39 -0600, John Marino wrote: > On 1/12/2017 20:36, Carlos J. Puga Medina wrote: > >=20 > > Author: cpm > > Date: Fri Jan 13 02:36:08 2017 > > New Revision: 431337 > > URL: https://svnweb.freebsd.org/changeset/ports/431337 > >=20 > > Log: > > =C2=A0 - Always check OPSYS along with OSVERSION > > =C2=A0 - Fix build on 11.0-STABLE [1] > >=20 > > =C2=A0 Reported by: Jonathan Chen <jonc@chen.org.nz> [1] via > > email > > =C2=A0 Reviewed by: rene > > =C2=A0 Approved by: chromium (rene) > > =C2=A0 MFH: 2017Q1 (blanket) > >=20 > > Modified: > > =C2=A0 head/www/chromium/Makefile > >=20 > > Modified: head/www/chromium/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- head/www/chromium/Makefile Fri Jan 13 02:18:47 2017=09 > > (r431336) > > +++ head/www/chromium/Makefile Fri Jan 13 02:36:08 2017=09 > > (r431337) > > @@ -187,13 +187,13 @@ GN_ARGS+=3D is_clang=3Dtrue > > =C2=A0EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-clang > > =C2=A0.endif > >=20 > > -.if ${OSVERSION} < 1200017 > > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} < 1100508 > > =C2=A0EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-old > > =C2=A0.else > > =C2=A0EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-libc++-new > > =C2=A0.endif > >=20 > > -.if ${OSVERSION} < 1100000 > > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} < 1100000 > > =C2=A0EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-10 > > =C2=A0.endif > >=20 > I'm not sure this change is correct. > It seems that none of the these extra patches should apply if OPSYS > is=C2=A0 > not FreeBSD, so it may have been better to wrap both of these=C2=A0 > conditional statements with ".if ${OPSYS} =3D=3D FreeBSD / .endif" so > that=C2=A0 > they are skipped e.g. DragonFly. >=20 Hi John, I think that this change doesn't affect to Dragonfly. According to bsd.port.mk we can set to "FreeBSD," "NetBSD," or "OpenBSD" as appropriate. Could you verify it? > John >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 > --- > This email has been checked for viruses by Avast antivirus software. > https://www.avast.com/antivirus >=20 --=20 Carlos Jacobo Puga Medina <cpm@FreeBSD.org> PGP fingerprint =3D C60E 9497 5302 793B CC2D BB89 A1F3 5D66 E6D0 5453 --=-AR6Xl0896djhAzAnMHGa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEExg6Ul1MCeTvMLbuJofNdZubQVFMFAlh4Qc1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2 MEU5NDk3NTMwMjc5M0JDQzJEQkI4OUExRjM1RDY2RTZEMDU0NTMACgkQofNdZubQ VFOAGwf/YEq2+X7QaYnlWrRwbdZHaZsHkM4l8gki6IisyeTj7mE3KhYZigNQHBZ3 kLuVNA3Vg7I8Vw08iTV7tUT1b6BpnBq/qRpagG7u6Z8LWmqPO4+K8OvyuLEcZ08q wiCFvZU388bA+XznqUKsa/MRC9t9HuPAh+B+4t6U9A2Rjlbt+kHgq3FVBK9TAipC aYd9GxrDa6JX+l0+nH92EwUO+LLUTzgE20vqnJ6gll9vGpy7OAFpwCwZr/HX/5Uq uKp8fQ1aTv6gQguc/na+D6sr+SYaoLkb0T435zmDVUg0b0oTgKWDKsjIUuCFAjEt 3m6GMC5ovlsb3dAhOaYe1aJgbRF4WQ== =d9Nt -----END PGP SIGNATURE----- --=-AR6Xl0896djhAzAnMHGa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1484276172.95107.4.camel>