Date: Wed, 31 May 2017 23:06:50 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Brooks Davis <brooks@FreeBSD.org> Cc: Ngie Cooper <ngie@FreeBSD.org>, Marcel Moolenaar <marcel@freebsd.org>, "Simon J. Gerraty" <sjg@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Message-ID: <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> In-Reply-To: <20170601050339.GA48398@spindle.one-eyed-alien.net> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_DA06CB10-94EA-4DD7-B34D-674163D3BACC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 31, 2017, at 10:03 PM, Brooks Davis <brooks@FreeBSD.org> wrote: >=20 > On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote: >> Author: ngie >> Date: Wed May 31 08:01:12 2017 >> New Revision: 319295 >> URL: https://svnweb.freebsd.org/changeset/base/319295 >>=20 >> Log: >> Update the usr.bin/mkimg golden test output files after = ^/head@r319125 >>=20 >> ^/head@r319125 changed the location of the backup pmbr, requiring = the >> output files to be regenerated, since they're binary disk dumps. >>=20 >> The output files were regenerated with "make rebase"--fixed in >> ^/head@r319294. >=20 > These should not be stored uuencoded. It serves no purpose other > than bloating the repo and causing spammy commit mails like this one > where we got a huge tail of garbage output. Hi Brooks, I=E2=80=99m not entirely sure why the files were uuencoded to be = honest. I think that=E2=80=99s a good question for Marcel and some of = the folks at Juniper, since they wrote the tool/tests. Thanks! -Ngie PS I agree based on what little I know, but I don=E2=80=99t necessarily = know what trade offs were made with writing these tests. --Apple-Mail=_DA06CB10-94EA-4DD7-B34D-674163D3BACC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJZL676AAoJEPWDqSZpMIYVaFEP/0TYeegYaOrr06PMIZWAILpK GSU+tTobSMU4CBEkyQaUuQACCcvytTaeRwDItpspCTUP97A5vHADDKgV9onBBp2f RSLiWaE23EQ1X+auLQOkm8ihKic8fvLQhlpXxCDyVanguByhn8LaIv2rMnWiADbF pdWPvi8mkmg+wO1c/uhJGjs7Wy/QTw5XVljBmd+d10ElKpWUGam5SL2FVuyA42Yh NPp6Jz+4CdpYpt89+O2FGdX3ZiUSIprOODNesPWzEHCIBfDBU2FnYipZZzDa1acD /j/T4msKUfNT4zQwGXS72yf57gEsgUY8LNzZ2Xx2JGZ+TrKKBgA79P3zZsgMOF7E nL2Fg/7bNxElfAP1jdb4rOBEY7F23tEZsLHGXIDIW1d6dBf5Cowao2vv+EpKVC8l QRSWflLEAw3zqGLj2s58aJjJUj16VmmYb3hBkdp9rNw/o7vJn5VsIcz336OpJ8LA s/NbJoSmPsnj8zPkHqu1gOTNj38jQu87Pm+asWG3u2Dfr5eYJ+FZi/A1BmI4ikPD +mCjwKfUt1luYeue9sWw/ouzV9GMomuEDllXOhAl9fB2nOtR6hciOfKyx7BNfnAW kFff7F9wuuddRU/pFpawuIsHZ/4nh3lf9G9JLbiAauDtUm+y45sHZrwbvnjDGWxd Ko9D8ZKiZKRFU9RcRDfp =5SHd -----END PGP SIGNATURE----- --Apple-Mail=_DA06CB10-94EA-4DD7-B34D-674163D3BACC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7FC9CB7D-CF96-4ACA-A38C-E82836127BA4>