Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Oct 2014 18:51:30 +0000
From:      Max Brazhnikov <makc@freebsd.org>
To:        Kris Moore <kmoore@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, yurkis@gmail.com, ports-committers@freebsd.org
Subject:   Re: svn commit: r370925 - in head/deskutils: . homerun
Message-ID:  <3258947.JIyEQJOWIn@mercury.ph.man.ac.uk>
In-Reply-To: <201410151436.s9FEabtv075435@svn.freebsd.org>
References:  <201410151436.s9FEabtv075435@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

this port needs more attention.

On Wed, 15 Oct 2014 14:36:37 +0000Wed Oct 15 14:36:36 2014 Kris Moore wrote:
> Author: kmoore
> Date: Wed Oct 15 14:36:36 2014
> New Revision: 370925
> URL: https://svnweb.freebsd.org/changeset/ports/370925
> QAT: https://qat.redports.org/buildarchive/r370925/
> 
> Log:
>   Homerun is a fullscreen launcher with content organized in tabs.
>   A tab is composed of several "sources". A source can provide one
>   or more sections to a tab. Homerun comes with a few built-in sources,
>   but custom sources can be written using libhomerun.
>   
>   WWW:    https://userbase.kde.org/Homerun
>   
>   Submitted by: Yuri Momotiuk <yurkis@gmail.com>
> 
> Added:
>   head/deskutils/homerun/
>   head/deskutils/homerun/Makefile   (contents, props changed)
>   head/deskutils/homerun/distinfo   (contents, props changed)
>   head/deskutils/homerun/pkg-descr   (contents, props changed)
>   head/deskutils/homerun/pkg-plist   (contents, props changed)
> Modified:
>   head/deskutils/Makefile
> 
> Modified: head/deskutils/Makefile
> ==============================================================================
> --- head/deskutils/Makefile	Wed Oct 15 14:10:17 2014	(r370924)
> +++ head/deskutils/Makefile	Wed Oct 15 14:36:36 2014	(r370925)
> @@ -86,6 +86,7 @@
>      SUBDIR += hamster-applet
>      SUBDIR += hebcal
>      SUBDIR += helpviewer
> +    SUBDIR += homerun
>      SUBDIR += horde-groupware
>      SUBDIR += horde-kronolith
>      SUBDIR += horde-mnemo
> 
> Added: head/deskutils/homerun/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/deskutils/homerun/Makefile	Wed Oct 15 14:36:36 2014	(r370925)
> @@ -0,0 +1,17 @@
> +# $FreeBSD$
> +
> +PORTNAME=	homerun
> +PORTVERSION=	0.2.3
> +CATEGORIES=	deskutils
> +MASTER_SITES=	http://download.kde.org/unstable/homerun/src/

MASTER_SITES=	KDE/unstable/${PORTNAME}/src/

> +
> +MAINTAINER=	yurkis@gmail.com
> +COMMENT=	Homerun is a fullscreen launcher with content organized in tabs. 

Comment shouldn't start with "foo is a" and should end without a period.
btw, portlint warns about this. 

> +
> +USES=	cmake tar:bzip2
> +USE_KDE4=	kdehier kdelibs kdeprefix automoc4 workspace
> +USE_QT4=	moc_build qmake_build rcc_build uic_build corelib gui
> +USE_XORG=	x11
> +CMAKE_ARGS+=	-DROOT_PREFIX:PATH=${STAGEDIR}

Does it make any effect?

> +.include <bsd.port.mk>
> 
> Added: head/deskutils/homerun/distinfo
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/deskutils/homerun/distinfo	Wed Oct 15 14:36:36 2014	(r370925)
> @@ -0,0 +1,2 @@
> +SHA256 (homerun-0.2.3.tar.bz2) = a6278c69ebcfa50efcbc6a472dc1e8d61a38c9413d771cfb6c51448a4d267657
> +SIZE (homerun-0.2.3.tar.bz2) = 164800
> 
> Added: head/deskutils/homerun/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/deskutils/homerun/pkg-descr	Wed Oct 15 14:36:36 2014	(r370925)
> @@ -0,0 +1,7 @@
> +Homerun is a fullscreen launcher with content organized in tabs. 
> +A tab is composed of several "sources". A source can provide one
> +or more sections to a tab. Homerun comes with a few built-in sources,
> +but custom sources can be written using libhomerun. 
> +
> +WWW:	https://userbase.kde.org/Homerun
> +
> 
> Added: head/deskutils/homerun/pkg-plist
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/deskutils/homerun/pkg-plist	Wed Oct 15 14:36:36 2014	(r370925)
> @@ -0,0 +1,86 @@
> +bin/homerunviewer
> +lib/libhomerun.so.0.0.0
> +lib/libhomerun.so.0
> +lib/libhomerun.so
> +lib/cmake/Homerun/HomerunTargets.cmake
> +lib/cmake/Homerun/HomerunTargets-release.cmake
> +lib/cmake/Homerun/HomerunConfig.cmake
> +lib/cmake/Homerun/HomerunConfigVersion.cmake
> +lib/kde4/plasma_applet_homerunlauncher.so
> +include/homerun/abstractsource.h
> +include/homerun/actionlist.h
> +include/homerun/homerun_export.h
> +include/homerun/libhomerun_config.h
> +include/homerun/pathmodel.h
> +include/homerun/sourceconfigurationwidget.h
> +lib/kde4/imports/org/kde/homerun/components/libcomponentsplugin.so
> +lib/kde4/imports/org/kde/homerun/components/private/IconLoader.qml

What kind of tool was used to create this plist? I'm not aware of any that
produces unsorted list. The reason to keep plist sorted is to reduce
meaningless repo churn on updates and to make real changes clear.

I've fixed all of above plus a couple of other problems with this port:
http://people.freebsd.org/~makc/patches/homerun.diff

Similar fixes are required for deskutils/kdeconnect.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3258947.JIyEQJOWIn>