Date: Wed, 20 Dec 2006 15:25:12 +0100 From: "Attilio Rao" <attilio@freebsd.org> To: "Martin Blapp" <mb@imp.ch> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern tty.c Message-ID: <3bbf2fe10612200625r527a7d2fj7319c9d6193c8816@mail.gmail.com> In-Reply-To: <20061220150622.V53548@godot.imp.ch> References: <200612192234.kBJMYYo0055529@repoman.freebsd.org> <3bbf2fe10612191850y3a546fcew486575385b1400df@mail.gmail.com> <20061220120419.M53548@godot.imp.ch> <3bbf2fe10612200441i2f658b59i83de7c21c7290ab1@mail.gmail.com> <20061220150622.V53548@godot.imp.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
2006/12/20, Martin Blapp <mb@imp.ch>: > > Hi, > > > No, it drops Giant for all the time it sleeps. > > Maybe the race is somewhere else. > > Yep, you are correct. It drops Giant for all the time. > > And during this time the session could be cleared > somewhere else because we don't held GIANT anymore. > > I don't understand your problem ? Quote: "Log: Giant might have been temporarily dropped while waiting for proctree_lock, allowing for an intervening tty_close() that cleared tp->t_session." so, as you have seen, when a thread is waiting against proctree_lock it doesn't held Giant. I don't understand the sense of your commit. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10612200625r527a7d2fj7319c9d6193c8816>