Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 May 2005 00:20:30 +0800 (CST)
From:      Yen-Ming Lee <leeym@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        ale@FreeBSD.org
Subject:   ports/81070: [PATCH] www/php-screw: randomize CRYPTKEY
Message-ID:  <20050515162030.AD8F73EA167@utopia.leeym.com>
Resent-Message-ID: <200505151630.j4FGUAJ9057864@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         81070
>Category:       ports
>Synopsis:       [PATCH] www/php-screw: randomize CRYPTKEY
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 15 16:30:10 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Yen-Ming Lee
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
FreeBSD Taiwan
>Environment:
System: FreeBSD utopia.leeym.com 5.4-STABLE FreeBSD 5.4-STABLE #0: Tue Apr 19 12:00:33 CST 2005
>Description:
- randomize CRYPTKEY

  I'm not sure if it's a good idea to randomize CRYPTKEY.
  If not, please ignore this PR and close it.

Port maintainer (ale@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

--- php-screw-1.3.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/www/php-screw/Makefile,v
retrieving revision 1.10
diff -u -u -r1.10 Makefile
--- Makefile	9 Feb 2004 11:43:36 -0000	1.10
+++ Makefile	15 May 2005 16:18:12 -0000
@@ -18,20 +18,14 @@
 
 PKGMESSAGE=	${WRKDIR}/pkg-message
 
-CRYPTKEY?=	11152, 368, 192, 1281, 62
-
 USE_PHP=	yes
 USE_PHPIZE=	yes
 
 CONFIGURE_ARGS+=--enable-php_screw=shared
 
-pre-everything::
-	@${ECHO} ""
-	@${ECHO} "To achieve real security, define your own encryption"
-	@${ECHO} "seed key (CRYPTKEY); longer is better."
-	@${ECHO} ""
-	@${ECHO} "make CRYPTKEY=\"234, 84, 39664, 771, 9853\""
-	@${ECHO} ""
+.include <bsd.port.pre.mk>
+
+CRYPTKEY!=	jot -r 5 0 32767 | ${XARGS} | ${SED} 's/ /, /g'
 
 post-patch:
 	@${ECHO} "short pm9screw_mycryptkey[] = { ${CRYPTKEY} };" > \
@@ -55,4 +49,4 @@
 post-install:
 	@${CAT} ${PKGMESSAGE}
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- php-screw-1.3.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050515162030.AD8F73EA167>