Date: Mon, 14 Mar 2011 11:34:12 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-drivers@freebsd.org Subject: Re: Allocating resources to isab children Message-ID: <201103141134.12832.jhb@freebsd.org> In-Reply-To: <4A3AEDA0-9AAA-4040-AC02-6416543A1B6D@freebsd.org> References: <3550EA55-ADDE-40AC-9C22-1FAC441A0BC8@freebsd.org> <AANLkTi=-NBmwh2nfWreJJtCNVHSXrcKSvh_Mb7jVWf2H@mail.gmail.com> <4A3AEDA0-9AAA-4040-AC02-6416543A1B6D@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, March 14, 2011 10:42:33 am Henrik Brix Andersen wrote: > Hi, > > On Mar 14, 2011, at 00:15, Philip Schulz wrote: > > I made my glxiic driver a child of isa(4) because I didn't know where > > else to put it. After all, the DIVIL contains a bunch of devices on > > legacy I/O addresses such as e.g. UARTs which are already managed by > > ISA device drivers. Also, I couldn't get glxiic to be a direct child > > of isab unless I added a device_add_child() to isab_attach() - > > something I didn't want to do because it would be non-generic. > > Finally, glxiic can't be a PCI device driver because on my system, the > > entire DIVIL announces itself as one single PCI function (15.0, seems > > to be the same on your system). If glxiic attached to that function, > > isab wouldn't be able to attach anymore and I'd lose all of the other > > ISA devices. Of course, I could have added the ISA bridge logic to > > glxiic as well, but then I'd have glxiic+isab merged in one driver. > > Right. I use DEVICE_IDENTIFY(9) to check the PCI device ID of the isab device and add a glxiic(4) child upon match. > This way, glxiic(4) becomes a child of isab. We could probably use this to replace a similar hack in place for one of the smbus(4) controller drivers (I think viapro or some such?) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103141134.12832.jhb>