Date: Mon, 2 Jan 2017 19:41:26 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311109 - head/usr.bin/patch Message-ID: <9c3fc378-ee5e-19ba-c286-1440d4b13615@FreeBSD.org> In-Reply-To: <CAG6CVpV7=Dx6VywV0MRY7z7LMwQrBcb-1qUhjngxjFsSZZHvHg@mail.gmail.com> References: <201701021823.v02INWXc028047@repo.freebsd.org> <CAG6CVpUUFoTZBO0Ja2aSn%2BeMi_BO0u131YKQ1yQumu%2BdRhVY3A@mail.gmail.com> <aa9172cb-cb95-36cf-c21d-48f8a7450ad5@FreeBSD.org> <CAG6CVpV7=Dx6VywV0MRY7z7LMwQrBcb-1qUhjngxjFsSZZHvHg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/02/17 17:54, Conrad Meyer wrote: > I was suggesting using UINT32_MAX/2 on all platforms (which is safe > everywhere). > Ah OK. INT_MAX is ~ (UINT_MAX / 2) so it's the same to use either. I just think it's clearer to use INT_MAX and the corresponding int type. The other issue is if diff(1) can handle such lines(?). Pedro. > Best, > Conrad > > On Mon, Jan 2, 2017 at 11:48 AM Pedro Giffuni <pfg@freebsd.org > <mailto:pfg@freebsd.org>> wrote: > > Hi; > > > > On 01/02/17 13:28, Conrad Meyer wrote: > > > IMO this patch was mostly fine, you just need to restrict line length > > > to UINT32_MAX/2 instead of UINT_MAX (== UINT32_MAX) for 32-bit > > > platforms. > > > > > > Best, > > > Conrad > > > > > > > I dislike the idea of special cases for some platforms. I guess moving > > to int/INT_MAX would be the way to go. > > > > TBH, no one has asked for patches wider than USHRT_MAX though. > > > > Pedro. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9c3fc378-ee5e-19ba-c286-1440d4b13615>