Date: Sun, 17 Jan 2010 23:19:42 -0800 From: Doug Barton <dougb@FreeBSD.org> To: "Philip M. Gollucci" <pgollucci@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, James E Risner <risner@mail.bullard.de>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/postgrey Makefile ports/mail/postgrey/files postgrey.in Message-ID: <4B540B8E.4050102@FreeBSD.org> In-Reply-To: <201001180014.o0I0ELwM042687@repoman.freebsd.org> References: <201001180014.o0I0ELwM042687@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Some of those things that are currently set as _flags look like they
should probably be set as command_args instead. Anything that is
required for the thing to run properly (such as the option to identify
the pidfile, and the option to daemonize) would fall into this category.
Also, you can (and probably should) simplify the script by setting
pidfile right after load_rc_config like this:
pidfile=${postgrey_pidfile:-/var/run/postgrey.pid}
Then use --pidfile=${pidfile} in the command_args.
hth,
Doug
On 01/17/10 16:14, Philip M. Gollucci wrote:
> pgollucci 2010-01-18 00:14:21 UTC
>
> FreeBSD ports repository
>
> Modified files:
> mail/postgrey Makefile
> mail/postgrey/files postgrey.in
> Log:
> - Fix the rc.d script
>
> PR: ports/139046 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=139046
> Submitted by: James E Risner <risner@mail.bullard.de>
> Approved by: maintainer timeout
>
> Revision Changes Path
> 1.22 +1 -0 ports/mail/postgrey/Makefile
> 1.3 +3 -2 ports/mail/postgrey/files/postgrey.in
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postgrey/Makefile.diff?&r1=1.21&r2=1.22&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postgrey/files/postgrey.in.diff?&r1=1.2&r2=1.3&f=h
>
--
Improve the effectiveness of your Internet presence with
a domain name makeover! http://SupersetSolutions.com/
Computers are useless. They can only give you answers.
-- Pablo Picasso
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B540B8E.4050102>