Date: Tue, 17 Jul 2001 10:25:11 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Harti Brandt <brandt@fokus.gmd.de> Cc: hackers@FreeBSD.ORG Subject: Re: Really simple patch... Message-ID: <94590.995358311@critter> In-Reply-To: Your message of "Tue, 17 Jul 2001 10:22:11 %2B0200." <20010717101638.V11504-100000@beagle.fokus.gmd.de>
next in thread | previous in thread | raw e-mail | index | archive | help
fixed. In message <20010717101638.V11504-100000@beagle.fokus.gmd.de>, Harti Brandt writes: > >Could please somebody make this little, trivial and obviuos patch, I >requested it a while ago, or should I make a PR for it?? > >Hi, > >()s are missing around the macro argument in cv_waitq_empty. The call > > if(!(cv_waitq_empty(&sc->foo_cv))) > ... > >will otherwise fail to compile. > >harti > >Index: condvar.h >=================================================================== >RCS file: /usr/ncvs/src/sys/sys/condvar.h,v >retrieving revision 1.2 >diff -r1.2 condvar.h >66c66 >< #define cv_waitq_empty(cvp) (TAILQ_EMPTY(&cvp->cv_waitq)) >--- >> #define cv_waitq_empty(cvp) (TAILQ_EMPTY(&(cvp)->cv_waitq)) > > >-- >harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private > brandt@fokus.gmd.de, harti@begemot.org > > >To Unsubscribe: send mail to majordomo@FreeBSD.org >with "unsubscribe freebsd-hackers" in the body of the message > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?94590.995358311>