Date: Sat, 13 Jul 2013 17:18:03 +0300 From: Mikolaj Golub <trociny@FreeBSD.org> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, Marko Zec <zec@fer.hr> Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130713141802.GG2757@gmail.com> In-Reply-To: <20130713111825.GE2757@gmail.com> References: <201307120803.r6C83ACp016523@svn.freebsd.org> <CAJ-Vmonrmgr3HJRzQtVmWp=8SkpSeWNVeBZgOnSnE72NNp=3DQ@mail.gmail.com> <CAG=rPVcxvWq-MoXADiv%2BgLY-d3hhv1GTMO1R14bhLRm9UB9DqA@mail.gmail.com> <20130712202710.GB2757@gmail.com> <CAJ-Vmomv1nEEq9HV9GreQg6KJGos6ffDhFcVUsUuzfCL6h-YQw@mail.gmail.com> <CAJ-Vmokm29XXbQr5uTwEbGGDYo-8WQNsp60b%2B7Khkteyh%2BO%2B6A@mail.gmail.com> <CAJ-VmomidFufKmGUb0YP2pHWu%2BpF2Os3Fo4JWzkMJDKLqP_ing@mail.gmail.com> <20130713073118.GC2757@gmail.com> <CAG=rPVe_F03LTt1K77p1BSw0hojMm-Ms-oZdhaFgo842AxkmhQ@mail.gmail.com> <20130713111825.GE2757@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 13, 2013 at 02:18:26PM +0300, Mikolaj Golub wrote: > I wonder if it fails on current too? It looks this code is not there > any more. I will try. Yes. It crashes on current too. In pfattach(). Also, loading ipfw and ipfw_nat causes panics in ipfw_init() and ipfw_nat_init(). Although this can be easily bandaged with CURVNET_SET(vnet0), it rather reveals problems with these modules. E.g. currently in ipfw_nat_init() we lock virtualized layer3_chain in vnet0 context, I think, to restrict the access to ipfw_nat_*_ptr variables during modification. But the access is not protected from another vnets, which might already exist at the moment when ipfw_nat is loaded. -- Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130713141802.GG2757>