Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Mar 2021 10:45:24 +0100
From:      Piotr Kubaj <pkubaj@anongoth.pl>
To:        Gerald Pfeifer <gerald@pfeifer.com>
Cc:        Mathieu Arnold <mat@freebsd.org>, Piotr Kubaj <pkubaj@freebsd.org>, Mark Linimon <linimon@lonesome.com>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r568012 - head/net/tightvnc
Message-ID:  <YFMhNG0qLYgt7EKT@KGPE-D16>
In-Reply-To: <739c1d5d-3a5f-cb4f-ebfa-56835044ac7e@pfeifer.com>
References:  <13e0fa6a-7ea4-d321-c75e-474eeb415ee9@pfeifer.com> <20210315112025.ij4l2oiegzkq2hhu@aching.in.mat.cc> <6fc69b3c-6b86-ffd9-9784-524868a8d951@pfeifer.com> <20210317111317.vlp7f7kqxwhwlsjd@aching.in.mat.cc> <20210317114507.edjpfbwtdd3krfdb@aching.in.mat.cc> <YFH8EjaCqdagExno@KGPE-D16> <20210317134119.bzvp2lfnpiewzl5k@aching.in.mat.cc> <YFIKC%2BtvNWzQy48y@KGPE-D16> <20210317171958.znakfw7uj543uc7z@aching.in.mat.cc> <739c1d5d-3a5f-cb4f-ebfa-56835044ac7e@pfeifer.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--/TJHlmFgvRtUHVeZ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

OK for me.

On 21-03-18 09:46:01, Gerald Pfeifer wrote:
> On Wed, 17 Mar 2021, Mathieu Arnold wrote:
> > First step could probably be to make a patch for `any` mean `yes`,
> > build stuff and look at the size of the explosion from afar.
>=20
> On most architectures (i386, amd64, aarch64,...) `any` has been=20
> equivalent to `yes` for years. This even is the case for ppc on=20
> FreeBSD 13+.  No explosion ahead. :-)
>=20
>=20
> On Wed, 17 Mar 2021, Piotr Kubaj wrote:
> > I know what you mean and this will just make more work for people carin=
g=20
> > about ARM / PPC. I add USE_GCC=3Dany simply because there ARE issues wi=
th=20
> > clang
>=20
> A key problem freshly introducing USE_GCC=3Dany is that most developers=
=20
> later will test on i386, amd64, maybe aarch64, where `any` is equivalent=
=20
> to `yes` and implies GCC 10, which is *very* different.
>=20
> Also, USE_GCC=3Dany implies something *very* different in case of ppc on=
=20
> different version of FreeBSD. That alone is prone to cause more work.
>=20
>=20
> On Wed, 17 Mar 2021, Mathieu Arnold wrote:
> > I have no idea of the state of USE_GCC=3Dany, as it is something nobody
> > should use nowadays in favor of USE_GCC=3Dyes (and Gerald says that oft=
en
> > enough), I would have thought that those were old stuff that dated back
> > from the dinosaurs era and that could be tried without gcc.
>=20
> Most ports featuring USE_GCC=3Dany fit your reference regarding the
> dinosaurs era. :-)
>=20
> As a first step, I am proposing the patch below.
>=20
> Any objections? Other thoughts?
>=20
> Gerald
>=20
>=20
> Make USE_GCC=3Dany equivalent to USE_GCC=3Dyes across the board, which
> already has been the case on amd64, aarch64, and i386 for years and
> now also powerpc64 with FreeBSD 13.
>=20
> Still leave USE_GCC=3Dany in place for ports currently using that in
> case someone wants to go through those.
>=20
> Index: Mk/bsd.gcc.mk
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- Mk/bsd.gcc.mk	(revision 568719)
> +++ Mk/bsd.gcc.mk	(working copy)
> @@ -9,9 +9,6 @@
>  # your port/system configuration.  This is the preferred use of USE_GCC.
>  # It uses the canonical version of GCC defined in bsd.default-versions.m=
k.
>  #
> -# USE_GCC=3Dany is similar, except that it also accepts the old GCC 4.2-
> -# based system compiler where still present.
> -#=20
>  # If your port needs a specific (minimum) version of GCC, you can easily
>  # specify that with a USE_GCC=3D statement.  Unless absolutely necessary
>  # do so by specifying USE_GCC=3DX+ which requests at least GCC version X.
> @@ -24,11 +21,12 @@
>  # If no arguments are specified, GCC is added as both a build dependency
>  # and a run time dependency.
>  #
> +# (USE_GCC=3Dany is deprecated and equivalent to USE_GCC=3Dyes nowadays.)
> +#=20
>  #
>  # Examples:
>  #   USE_GCC=3D	yes			# port requires a current version of GCC
>  #							# as defined in bsd.default-versions.mk.
> -#   USE_GCC=3D	any			# port requires GCC 4.2 or later.
>  #   USE_GCC=3D	9+			# port requires GCC 9 or later.
>  #   USE_GCC=3D	8			# port requires GCC 8.
>  #   USE_GCC=3D	yes:build	# port requires a current version of GCC at
> @@ -71,16 +69,6 @@
> =20
>  .if defined(USE_GCC) && !defined(FORCE_BASE_CC_FOR_TESTING)
> =20
> -.if ${USE_GCC} =3D=3D any && exists(/usr/bin/gcc)
> -CC:=3D		gcc
> -CXX:=3D		g++
> -. if exists(/usr/bin/gcpp)
> -CPP:=3D		gcpp
> -. else
> -CPP:=3D		cpp
> -. endif
> -.else # The regular approach, not using the age-old base compiler.
> -
>  # Handle USE_GCC=3Dyes and USE_GCC=3Dany.
>  .if ${USE_GCC} =3D=3D yes || ${USE_GCC} =3D=3D any
>  USE_GCC=3D	${GCC_DEFAULT}+
> @@ -154,8 +142,6 @@
>  USE_BINUTILS=3D	yes
>  .endif
> =20
> -.endif # USE_GCC=3Dany
> -
>  .endif # defined(_USE_GCC) && !defined(FORCE_BASE_CC_FOR_TESTING)
> =20
> =20

--/TJHlmFgvRtUHVeZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmBTITQACgkQelmbhSCD
nJ2TfA//T5AzM1fQLmM4F7jWUFqlH20YUtMkgsXmPneT0kYsAKqzlakoBdt2psMe
y2DssRCMAxmfVXwKUgg0HsFLYHIjWOtn3J5StJpWQBH35LkzzYPE6l15IxHAtTP0
8o255W6c9d9NDU1AtkZGAZZW0+xYJRwLSFRr0plaufNf2ZEKhHVJu/8G9sHgdygf
B2J3JMqB3aVw5OLQVeOxNBDWmEa7fmwm6gCQjKY9Ou+Q1u4KTsxT2gToXZcDVhq0
XIejBKi3Z49Il67CzfnXaoMPXs0BQKSDXGnsKYjNbkgNUPgtkq/SzAkxMTmROhKf
+xTguR3mgCMoyk2QefviH1sCOr22FKr0wzcoLEGc6FRPrQ+96V//XPiG+vS9e/pl
0KiYgPQHpwFlo/3hgrT0JcsX9foSYk2ce1998g9RbyzrNlSatP9fVn0N/RXXyT+F
U77n0ItdfvbP/QVyWXe3/E0tSmqTMfoJyamJv+dH653aehBQlEQmBfEP6A26QVO/
C1cEyBc6WmZUbbFVUKwLsjBN5fsjEQsw+nS1p26YSlqhKAF15Juvpj7Ij5rcyonO
HIXoC56w+lZz8mm06hqioWZrMDBzJb3LAgcKBELRtLg4U0kIHj6DqWmRr/1mIiwG
35yj5i8Jx0sIwSartSjxtkZFZbROO0TB7mYqq5WnMFX9iE9zBmM=
=Q53G
-----END PGP SIGNATURE-----

--/TJHlmFgvRtUHVeZ--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YFMhNG0qLYgt7EKT>