Date: Sun, 05 Dec 2004 20:24:58 -0800 From: Sean McNeil <sean@mcneil.com> To: pb@FreeBSD.org, dvdauthor-users@lists.sourceforge.net Cc: ports@freebsd.org Subject: multimedia/dvdauthor - readxml.c:utf8tolocal is not 64-bit clean Message-ID: <1102307098.90991.4.camel@server.mcneil.com>
next in thread | raw e-mail | index | archive | help
--=-XMkvLlK+g0LhyVFG1VC7
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
This routine calls iconv with the assumption that int <-> size_t plus
has a bugus cast. The patch below makes spumux work on my FreeBSD/amd64
system.
--- dvdauthor-0.6.10/src/readxml.c.orig Fri Mar 12 23:57:39 2004
+++ dvdauthor-0.6.10/src/readxml.c Sun Dec 5 20:19:28 2004
@@ -221,13 +221,13 @@
char *utf8tolocal(const char *in)
{
iconv_t c=3Dget_conv();
- int inlen=3Dstrlen(in);
- int outlen=3Dinlen*5;
+ size_t inlen=3Dstrlen(in);
+ size_t outlen=3Dinlen*5;
char *r=3Dmalloc(outlen+1);
char *out=3Dr;
- int v;
+ size_t v;
=20
- v=3Diconv(c,ICONV_CAST &in,&inlen,&out,&outlen);
+ v=3Diconv(c,&in,&inlen,&out,&outlen);
if(v=3D=3D-1) {
fprintf(stderr,"ERR: Cannot convert UTF8 string '%s': %s\n",in,st=
rerror(errno));
exit(1);
--=-XMkvLlK+g0LhyVFG1VC7
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQBBs98ayQsGN30uGE4RAnTLAJ9SGpt8mJq21fmXIdE7rZ2epaVN5QCg5kOR
VqQYWof1AhTH70laLOl/LPY=
=+cn1
-----END PGP SIGNATURE-----
--=-XMkvLlK+g0LhyVFG1VC7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1102307098.90991.4.camel>