Date: Fri, 3 Feb 2017 21:55:35 +0100 From: Matthias Andree <matthias.andree@gmx.de> To: ports-committers@freebsd.org, freebsd-ports <freebsd-ports@freebsd.org> Cc: John Marino <marino@FreeBSD.org> Subject: Re: svn commit: r432796 - in head/graphics: rawtherapee rawtherapee-devel Message-ID: <f2e8dfd9-3d5d-668a-47c3-f7f50b1b9917@gmx.de> In-Reply-To: <201701291922.v0TJMlQE038923@repo.freebsd.org> References: <201701291922.v0TJMlQE038923@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 29.01.2017 um 20:22 schrieb John Marino: > Author: marino > Date: Sun Jan 29 19:22:47 2017 > New Revision: 432796 > URL: https://svnweb.freebsd.org/changeset/ports/432796 >=20 > Log: > graphics/rawtherapee(-devel): Fix OSVERSION, use with OPSYS > =20 > The OSVERSION for FreeBSD 10.3 is 1003000, not 1030000. The last com= mit > blocked FreeBSD 10.3 too. OSVERSION is also supposed to be used in > conjunction with OPSYS. > =20 > Approved by: just-fix-it >=20 > Modified: > head/graphics/rawtherapee-devel/Makefile > head/graphics/rawtherapee/Makefile >=20 > Modified: head/graphics/rawtherapee-devel/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/graphics/rawtherapee-devel/Makefile Sun Jan 29 19:19:06 2017 (= r432795) > +++ head/graphics/rawtherapee-devel/Makefile Sun Jan 29 19:22:47 2017 (= r432796) > @@ -76,7 +76,8 @@ OPTIMIZED_CFLAGS_CFLAGS=3D -O3 -funroll-lo > # ------------------------------------------------------------------- > # > =20 > -.if ${OSVERSION} < 1030000 > +.if ${OPSYS} =3D=3D FreeBSD > +.if ${OSVERSION} < 1003000 > IGNORE=3D is only for supported FreeBSD releases > .endif > Good catch, John, and thanks for the fix-up. I have one nit to pick about the OPSYS - where is it documented that OPSYS is mandatory for OSVERSION? It's not in bsd.port.mk unless I dive deep into the implementation, and not in the porter's handbook. I'm a FreeBSD ports committer and will not proactively deal with keeping my stuff compatible with other systems, let alone test there. Bottom line: I regularly omit the OPSYS checks because I have zero clue about the related versions on other systems, nor do I care.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f2e8dfd9-3d5d-668a-47c3-f7f50b1b9917>