Date: Wed, 13 Aug 2008 16:19:38 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: freebsd-multimedia@FreeBSD.org, ariff@FreeBSD.org Subject: Re: RFC: massive snd_hda driver update to better conform UAA specification Message-ID: <48A2DF6A.4090807@FreeBSD.org> In-Reply-To: <20080813144323.191755ysxy2w38so@webmail.leidinger.net> References: <48A20E02.6070609@FreeBSD.org> <20080813144323.191755ysxy2w38so@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Leidinger wrote: >> I have made major snd_hda driver rewrite. I will be grateful for >> reviews and any positive or negative feedbacks. > > Have you already asked Ariff for a review? I've CCed him... I have written to him several times but with no reply. >> Here is my patches: http://people.freebsd.org/~mav/ >> >> For 8-CURRENT use: >> http://people.freebsd.org/~mav/hda.20080812.patch > > I can not do a technical about this stuff, but I noticed that you use > comments to disable code. Please use "#if 0" instead of comments to > disable code. It's temporal. Mostly it's code parts which I haven't yet decided needed they or not. I will cleanup this in final version. Now it is just a first preview made to collect some initial feedbacks about codecs and setups I am unable to test myself. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48A2DF6A.4090807>