Date: Mon, 27 Oct 2014 17:20:34 +0100 From: Kurt Jaeger <pi@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Kurt Jaeger <pi@freebsd.org> Subject: Re: svn commit: r273734 - head/bin/dd Message-ID: <20141027162034.GN1492@f10.opsec.eu> In-Reply-To: <20141028005225.S2013@besplex.bde.org> References: <201410271138.s9RBcHrA002447@svn.freebsd.org> <20141028005225.S2013@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! > > Log: > > bin/dd: Fix incorrect casting of arguments [...] > Both of these work correctly in my version (with a relatively small patch > and no breakage of other cases). (I actually typed large values as -1 > and 11111111111111111111111111. -1 means (uintmax_t)-1 although this > is undocumented and now broken). So, given this detailed review, should I revert the change ? -- pi@FreeBSD.org +49 171 3101372 6 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141027162034.GN1492>