Date: Sat, 25 May 2019 08:36:31 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Yuri <yuri@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r494857 - in head/multimedia/webcamoid: . files Message-ID: <alpine.LSU.2.21.1905250832020.7670@anthias.pfeifer.com> In-Reply-To: <73df7274-1866-1f9f-3b4b-bc74eacff8e2@freebsd.org> References: <201903062230.x26MUo8W039525@repo.freebsd.org> <alpine.LSU.2.21.1903072009030.4540@anthias.pfeifer.com> <73df7274-1866-1f9f-3b4b-bc74eacff8e2@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 7 Mar 2019, Yuri wrote:
>>> # Workaround for Bug#224137: devel/qt5-qmake: Doesn't use the right
>>> compiler in case USE_GCC is selected
>>> BINARY_ALIAS= g++=${CXX}
>> ...this cannot be right any longer. Or at a minimum the comment
>> referring to USE_GCC cannot be?
> There are some architectures that use gcc as a default compiler, so
> this line is relevant, but it could use if/endif block conditioned
> on gcc being a compiler.
Yes, but this port does not employ USE_GCC any more, so the comment
is a bit confusuing (even if it's a reference).
> I will add this, and related notes to the port.
You haven't made such changes yet, have you?
Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1905250832020.7670>