Date: Tue, 23 Jan 2001 09:43:22 +1030 From: Greg Lehey <grog@lemis.com> To: Luigi Rizzo <luigi@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c Message-ID: <20010123094322.J3066@wantadilla.lemis.com> In-Reply-To: <200101222304.f0MN4DM06518@freefall.freebsd.org>; from luigi@FreeBSD.org on Mon, Jan 22, 2001 at 03:04:13PM -0800 References: <200101222307.f0MN7ab09050@freefall.freebsd.org> <200101222304.f0MN4DM06518@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, 22 January 2001 at 15:04:13 -0800, Luigi Rizzo wrote: > luigi 2001/01/22 15:04:13 PST > > Modified files: > sys/netinet ip_dummynet.c > Log: > Change critical section protection for dummynet from splnet() to > splimp() -- we need it because dummynet can be invoked by the > bridging code at splimp(). > > This should cure the pipe "stalls" that several people have been > reporting on -stable while using bridging+dummynet (the problem > would not affect routers using dummynet). This looks like a null change. splimp() and splnet() are both dummy functions in -CURRENT. On Monday, 22 January 2001 at 15:07:36 -0800, Luigi Rizzo wrote: > luigi 2001/01/22 15:07:36 PST > > Modified files: (Branch: RELENG_4) > sys/netinet ip_dummynet.c > Log: > MFC (bugfix): change critical section protection from splnet() to splimp() > so we do not get inconsistencies (leading to traffic stalls) > when dummynet is used with bridging. > > The error was reported by quite a few people over time. Hmm. We have an unofficial rule (hopefully soon to become official) that MFCs should be done not less than three days after the commit to -STABLE. I think that exceptions should be justified in the commit log. On the other hand, I suspect you really tested this under -STABLE, and the corresponding fix doesn't mean anything in -CURRENT, so I suppose that's a justification. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010123094322.J3066>