Date: Sat, 30 Aug 2014 09:22:15 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Ed Schouten <ed@80386.nl> Cc: freebsd-toolchain@freebsd.org, freebsd-arch@freebsd.org Subject: Re: Lock annotations: enable them for libpthread, libstdthreads Message-ID: <20140830162215.GA94722@troutmask.apl.washington.edu> In-Reply-To: <CAJOYFBB4%2BO6N2yQDei7jNxKAb4T1wZ=HjiSV7GHF7gYcHB3auA@mail.gmail.com> References: <CAJOYFBBbzu9ouwfUk1%2B1MLW0B2y%2B5JTD9-b0%2BkiymOT=xKU0uQ@mail.gmail.com> <20140828171859.GA81757@troutmask.apl.washington.edu> <CAJOYFBAo6KOuWuXcduA8DJZxNg7W8bAhM5ydGAhPKCdLMjWsvQ@mail.gmail.com> <CAJOYFBB4%2BO6N2yQDei7jNxKAb4T1wZ=HjiSV7GHF7gYcHB3auA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 30, 2014 at 07:33:27AM +0200, Ed Schouten wrote: > > On 28 August 2014 19:34, Ed Schouten <ed@80386.nl> wrote: > > My gut feeling is that impact is minimal. Buildworlds seem to take > > approximately the same time, mainly because we don't have that many > > annotated objects/functions/expressions. I will do some measurements. > > Some measurements: I've done five 'make buildworlds' with > -Wthread-safety and five without. This was just a single-threaded > build (no -j). Real time to build world: > > -Wthread-safety > > 1:12:55.60 > 1:12:48.81 > 1:12:56.33 > 1:12:44.58 > 1:12:48.14 > > -Wno-thread-safety > > 1:12:50.50 > 1:12:52.43 > 1:12:48.20 > 1:12:42.85 > 1:12:43.19 > > That said, this a pretty fast box (i7 4770) with 32 GB of RAM. > Unfortunately, I currently don't have any system running FreeBSD that > is significantly slower than that. So if you still have any concerns > regarding build times, I would really appreciate it if you'd test this > patch yourself. > Thanks for testing. The above reduces my fear of feature creep where each change only adds a little bit more time to buildworld. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140830162215.GA94722>