Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Mar 2018 15:46:53 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r331432 - head/sys/i386/i386
Message-ID:  <201803231546.w2NFkrl3077145@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Fri Mar 23 15:46:53 2018
New Revision: 331432
URL: https://svnweb.freebsd.org/changeset/base/331432

Log:
  There is no need to disable interrupts around npxsave call.
  
  i386 was changed to only require critical section around the thread
  FPU state manipulations, and vm86_bioscall callers already enter
  critical section for other reasons.
  
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week

Modified:
  head/sys/i386/i386/vm86bios.s

Modified: head/sys/i386/i386/vm86bios.s
==============================================================================
--- head/sys/i386/i386/vm86bios.s	Fri Mar 23 15:44:31 2018	(r331431)
+++ head/sys/i386/i386/vm86bios.s	Fri Mar 23 15:46:53 2018	(r331432)
@@ -61,8 +61,6 @@ ENTRY(vm86_bioscall)
 	pushl	%edi
 	pushl	%gs
 
-	pushfl
-	cli
 	movl	PCPU(CURTHREAD),%ecx
 	cmpl	%ecx,PCPU(FPCURTHREAD)	/* do we need to save fp? */
 	jne	1f
@@ -73,8 +71,6 @@ ENTRY(vm86_bioscall)
 	addl	$4,%esp
 	popl	%edx			/* recover our pcb */
 1:
-	popfl
-
 	movl	SCR_VMFRAME(%edx),%ebx	/* target frame location */
 	movl	%ebx,%edi		/* destination */
 	movl    SCR_ARGFRAME(%edx),%esi	/* source (set on entry) */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201803231546.w2NFkrl3077145>