Date: Sun, 03 Jun 2018 23:27:20 +0200 From: "Ronald Klop" <ronald-lists@klop.ws> To: "Eitan Adler" <eadler@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, "Florian Smeets" <flo@smeets.xyz> Subject: Re: svn commit: r334474 - head/usr.bin/top Message-ID: <op.zj1xvu1zkndu52@klop.ws> In-Reply-To: <bea6b96c-d312-2c45-ccc2-f6498df5cb2c@smeets.xyz> References: <201806010551.w515pfoB090926@repo.freebsd.org> <bea6b96c-d312-2c45-ccc2-f6498df5cb2c@smeets.xyz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 03 Jun 2018 19:19:47 +0200, Florian Smeets via svn-src-all <svn-src-all@freebsd.org> wrote: > On 01.06.18 07:51, Eitan Adler wrote: >> Author: eadler >> Date: Fri Jun 1 05:51:40 2018 >> New Revision: 334474 >> URL: https://svnweb.freebsd.org/changeset/base/334474 >> >> Log: >> top(1): Display of TID when using 'H' flag >> >> Some users prefer seeing the TID when viewing individual threads. This >> makes sense as the PID will be the same for multiple entries. An >> attempt >> was made to include both, but there is insufficient room. As such, >> using >> the TID. >> >> While here, rename the header variables to be more understandable. >> >> Discussed with: mmacy >> Reported on: 2009-10-07 >> > > Hi, > > I think this is a mistake. The 'H' flag should keep the PID, AFAIK you > cannot use the TID anywhere in top in contrast to the PID. I usually > start top with the 'S' and 'H' flags. Now I cannot use 'k' to kill a > process in that view, as I don't see the PID. IMHO showing TIDs should > be a separate flag, 'h' maybe, as this commit changes current/expected > behavior (POLA?). > > Also, this is not documented in the man page. > > Florian > +1 for Florian I also like the PIDs to see which threads belong to the same process. Ronald.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.zj1xvu1zkndu52>