Date: Sat, 25 Apr 2015 08:38:54 -0600 From: Adam Weinberger <adamw@adamw.org> To: Emanuel Haupt <ehaupt@FreeBSD.org> Cc: Renato Botelho <garga@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, adamw@FreeBSD.org Subject: Re: svn commit: r384682 - in head/security/keychain: . files Message-ID: <8CD89C9F-D73F-494B-8F93-102CFBE5C0A0@adamw.org> In-Reply-To: <20150425150722.568d8d52eb71eb774c29a70a@FreeBSD.org> References: <201504242009.t3OK9vtp090926@svn.freebsd.org> <20150425114020.4743fe0a5771addb3db585b9@FreeBSD.org> <20150425150722.568d8d52eb71eb774c29a70a@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 25 Apr, 2015, at 7:07, Emanuel Haupt <ehaupt@FreeBSD.org> wrote: >=20 > Emanuel Haupt <ehaupt@FreeBSD.org> wrote: >> Renato Botelho <garga@FreeBSD.org> wrote: >>> Author: garga >>> Date: Fri Apr 24 20:09:57 2015 >>> New Revision: 384682 >>> URL: https://svnweb.freebsd.org/changeset/ports/384682 >>>=20 >>> Log: >>> Update to 2.8.0 >>>=20 >>> PR: 199300 (based on) >>> Submitted by: adamw@ >>=20 >> After the update I get: >>=20 >> $ keychain=20 >> /usr/local/bin/keychain: shopt: not found >> /usr/local/bin/keychain: 848: Syntax error: "(" unexpected (expecting >> ")") >>=20 >=20 > Looking at it a bit closer shows that the new version sets: >=20 > shopt -s extglob >=20 > but uses: >=20 > #!/bin/sh >=20 > This is probably no problem on most Linuxes that simply link /bin/sh > to /bin/bash but it won't work on FreeBSD. >=20 > The way I see it keychain needs to either start using >=20 > #!/usr/local/bin/bash >=20 > as shebang or the expressions that require extglob need to be > made FreeBSD /bin/sh compatible. The first one is IMHO better > for future maintainability. You're completely right. I botched the patch. I've attached a patch that = fixes that (as well as removing stale dependencies that I should have = included in the original patch) to the original PR, 199300. Sorry, garga. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8CD89C9F-D73F-494B-8F93-102CFBE5C0A0>