Date: Sun, 21 Jul 1996 14:26:37 +1000 From: Bruce Evans <bde@zeta.org.au> To: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, joerg@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa aha1542.c Message-ID: <199607210426.OAA24600@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified: sys/i386/isa aha1542.c > Log: > Replace the annoying calls to Debugger() by panic()'s in the > #ifdef DIAGNOSTIC case, and a warning only otherwise. I think they should be panics in all cases. The original version may have expected Debugger() to cause a fatal trap if ddb is not installed. ISTR "fixing" Debugger() to make it non-fatal. This was a mistake. > People who want them to break into the debugger can always set the > breakpoint explicitly. The existing behaviour was a misfeature from Yes, code with Debugger() in it (except code to explicitly trap to the debugger) shouldn't be committed. > the beginning, in the (wrong) assumption that the SCSI controller must > always be of essential importance to the entire system. It is, if the alterative is to write corrupted data. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199607210426.OAA24600>