Date: Tue, 7 Dec 2010 19:02:38 +0100 From: Attilio Rao <attilio@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: atomic_set_xxx(&x, 0) Message-ID: <AANLkTimCzDA5hkv29DEWKT3FFHibstHgtyrmeP_uBy2w@mail.gmail.com> In-Reply-To: <4CFE75D3.4050009@freebsd.org> References: <4CFE75D3.4050009@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2010/12/7 Andriy Gapon <avg@freebsd.org>: > > $ glimpse atomic_set_ | fgrep -w 0 > /usr/src/sys/dev/arcmsr/arcmsr.c: =C2=A0 =C2=A0 =C2=A0 atomic_set_int(&ac= b->srboutstandingcount, 0); > /usr/src/sys/dev/arcmsr/arcmsr.c: =C2=A0 =C2=A0 =C2=A0 atomic_set_int(&ac= b->srboutstandingcount, 0); > /usr/src/sys/dev/jme/if_jme.c: =C2=A0atomic_set_int(&sc->jme_morework, 0)= ; > /usr/src/sys/dev/jme/if_jme.c: =C2=A0atomic_set_int(&sc->jme_morework, 0)= ; > /usr/src/sys/dev/ale/if_ale.c: =C2=A0atomic_set_int(&sc->ale_morework, 0)= ; > /usr/src/sys/mips/rmi/dev/xlr/rge.c: > atomic_set_int(&(priv->frin_to_be_sent[i]), 0); > /usr/src/sys/dev/drm/drm_irq.c: > atomic_set_rel_32(&dev->vblank[i].count, 0); > /usr/src/sys/dev/cxgb/ulp/tom/cxgb_tom.c: =C2=A0 =C2=A0 =C2=A0 atomic_set= _int(&t->tids_in_use, 0); > > I wonder if these are all bugs and atomic_store_xxx() was actually intend= ed? Besides, we assume store on the int boundary is implicitly atomic on all architectures on FreeBSD then, unless a memory barriers is needed, there is no need to use atomic_* in "store" cases. Attilio --=20 Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimCzDA5hkv29DEWKT3FFHibstHgtyrmeP_uBy2w>