Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Apr 1997 23:52:39 -0600
From:      Steve Passe <smp@csn.net>
To:        Peter Wemm <peter@spinner.dialix.com>
Cc:        freebsd-smp@FreeBSD.org
Subject:   Re: panic: 8254 redirect impossible.. 
Message-ID:  <199704260552.XAA11003@Ilsa.StevesCafe.com>
In-Reply-To: Your message of "Sat, 26 Apr 1997 13:01:09 %2B0800." <199704260501.NAA00297@spinner.DIALix.COM> 

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

I recently commited a version of mp_machdep.c that introduces a bug that may
cause a panic during boot with the message:

8254 redirect impossible

here's a patch to remove it IF it bites you:

*** mp_machdep.c~	Thu Apr 24 21:11:27 1997
--- mp_machdep.c	Fri Apr 25 23:46:34 1997
***************
*** 603,609 ****
--- 603,611 ----
  
  static int	nintrs;
  
+ #if defined(FIX_MP_TABLE_WORKS)
  static void	fix_mp_table	__P((void));
+ #endif /* FIX_MP_TABLE_WORKS */
  
  static void	processor_entry	__P((proc_entry_ptr entry, int* cpu));
  static void	io_apic_entry	__P((io_apic_entry_ptr entry, int* apic));
***************
*** 739,752 ****
--- 741,757 ----
      /* record # of IO APICs found */
      nintrs = intr;
  
+ #if defined(FIX_MP_TABLE_WORKS)
      /* post scan cleanup */
      fix_mp_table();
+ #endif /* FIX_MP_TABLE_WORKS */
  
      /* report fact that its NOT a default configuration */
      return 0;
  }
  
  
+ #if defined(FIX_MP_TABLE_WORKS)
  /*
   * parse an Intel MP specification table
   */
***************
*** 816,822 ****
  	}
      }
  }
! 
  
  /*
   * 
--- 821,827 ----
  	}
      }
  }
! #endif /* FIX_MP_TABLE_WORKS */
  
  /*
   * 
***************
*** 1020,1026 ****
--- 1025,1033 ----
  
      for (intr = 0; intr < nintrs; ++intr)	/* search each record */
  	if ((INTTYPE(intr) == 0)
+ #if defined(FIX_MP_TABLE_WORKS)
  	     && (SRCBUSID(intr) == pciBus)
+ #endif /* FIX_MP_TABLE_WORKS */
  	     && (SRCBUSDEVICE(intr) == pciDevice)
  	     && (SRCBUSLINE(intr) == pciInt))	/* a candidate IRQ */
  	    if (apic_int_is_bus_type( intr, PCI ))	/* check bus match */

--
Steve Passe	| powered by
smp@csn.net	|            Symmetric MultiProcessor FreeBSD





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199704260552.XAA11003>