Date: Mon, 5 Mar 2001 01:26:56 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Andrea Campi <andrea@webcom.it> Cc: arch@FreeBSD.org Subject: Re: Using CPUTYPE in COPTFLAGS Message-ID: <20010305012655.A67721@mollari.cthul.hu> In-Reply-To: <20010305101156.A367@webcom.it>; from andrea@webcom.it on Mon, Mar 05, 2001 at 10:11:56AM %2B0100 References: <20010304175829.A45353@mollari.cthul.hu> <20010304180911.A45581@mollari.cthul.hu> <20010305101156.A367@webcom.it>
next in thread | previous in thread | raw e-mail | index | archive | help
--J/dobhs11T7y2rNN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Mar 05, 2001 at 10:11:56AM +0100, Andrea Campi wrote:
> > Index: share/mk/bsd.cpu.mk
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > RCS file: /mnt/ncvs/src/share/mk/bsd.cpu.mk,v
> > retrieving revision 1.2
> > diff -u -r1.2 bsd.cpu.mk
> > --- share/mk/bsd.cpu.mk 2001/02/27 11:21:47 1.2
> > +++ share/mk/bsd.cpu.mk 2001/03/05 01:50:44
> > @@ -28,46 +28,52 @@
> > # after /etc/make.conf so it can react to the local value of CPUTYPE
> > # defined therein.
> > =20
> > -.if !defined(NO_CPU_CFLAGS)
> > +.if !defined(NO_CPU_CFLAGS) || !defined(NO_CPU_COPTFLAGS)
> > . if ${MACHINE_ARCH} =3D=3D "i386"
> > . if ${CPUTYPE} =3D=3D "k7"
> > -CFLAGS +=3D -march=3Dk6 # gcc doesn't support athlon yet, but it will
> > +CPUCFLAGS =3D -march=3Dk6 # gcc doesn't support athlon yet, but it will
> > . elif ${CPUTYPE} =3D=3D "k6-2"
> > -CFLAGS +=3D -march=3Dk6
> > +CPUCFLAGS =3D -march=3Dk6
> > . elif ${CPUTYPE} =3D=3D "k6"
>=20
> Are you sure this is what you really want? If I have
>=20
> # NO_CPU_CFLAGS=3Dno
> NO_CPU_COPTFLAGS=3Dyes
>=20
> then the `if' evaluates to true and you end up with CPUCFLAGS defined. If=
this
> is intended, it's at least not very intuitive...
Yes, but CPUCFLAGS is only used internally, and it will only be added
to CFLAGS or COPTFLAGS if the NO_* switches aren't defined.
Kris
--J/dobhs11T7y2rNN
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQE6o1vfWry0BWjoQKURAqiNAKC7xiaKGsoulMvisA6j6RKB8x2YZACdE8uR
OqOzMI76msvzRWyOoRsehM0=
=IwyI
-----END PGP SIGNATURE-----
--J/dobhs11T7y2rNN--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010305012655.A67721>