Date: Sun, 15 May 2005 18:41:01 +0200 From: Johan van Selst <johans@stack.nl> To: Thierry Thomas <thierry@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/81047: [maintainer] math/gap: update to 4.4.5 Message-ID: <20050515164101.GA79599@taz.gletsjer.net> In-Reply-To: <200505150951.j4F9pmni024169@freefall.freebsd.org> References: <200505150951.j4F9pmni024169@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thierry Thomas wrote: > Committed, thanks! Thank you. > Remarks: it does not respect CFLAGS, and CFLAGS is not copied > in c_options and c_dyn_options of gac; could you please check > that? Good point. Including CFLAGS options during the build can be done by setting COPTS. Please change the build target to: do-build: (cd ${GAP_WRKSRC}; make COPTS="${CFLAGS}") Fixing the options in gac is a bit tricky. It should probably use the CFLAGS that are set when you actually call gac, and not the default from when the program was installed. This can be done by including the following patch (as files/patch-gap4r4_cnf_gac.in): --- gap4r4/cnf/gac.in.orig Sun May 15 18:26:27 2005 +++ gap4r4/cnf/gac.in Sun May 15 18:26:23 2005 @@ -67,13 +67,13 @@ stat_identifier="USER"; # These three should be filled in by the standard autoconf procedures c_compiler="@CC@" -c_options="@CFLAGS@" +c_options="@CFLAGS@ ${CFLAGS}" c_linker="@CC@" -c_link_options="" +c_link_options="${LDFLAGS}" c_libs="@LIBS@" # These three will need special care -c_dyn_options="@CDYNOPTIONS@" +c_dyn_options="@CDYNOPTIONS@ ${CFLAGS}" c_dyn_linker="@CDYNLINKER@" c_dyn_linking="@CDYNLINKING@" c_dynlibs="@C_DYNLIBS@"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050515164101.GA79599>