Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Jul 2015 06:31:25 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Thomas Zander <riggs@freebsd.org>
Cc:        Koop Mast <kwm@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r392294 - in head/graphics: . ImageMagick7 ImageMagick7-nox11
Message-ID:  <20150717063125.GB48401@FreeBSD.org>
In-Reply-To: <CAFU734zegQHXVnxYtuyYtOPtzhH9rdOo1-ZEkP2GkALZnLoT9Q@mail.gmail.com>
References:  <201507161230.t6GCUSJI070228@repo.freebsd.org> <CAFU734zegQHXVnxYtuyYtOPtzhH9rdOo1-ZEkP2GkALZnLoT9Q@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 17, 2015 at 07:52:01AM +0200, Thomas Zander wrote:
> On 16 July 2015 at 14:30, Koop Mast <kwm@freebsd.org> wrote:
> > +.if ${USER} == kwm
> > +upload:
> > +       scp ${DISTDIR}/${DISTNAME}.tar.xz \
> > +               kwm@freefall.freebsd.org:public_distfiles/
> > +.endif
> 
> This USER clause seems to disturb some parts of our toolchain. I get
> this e.g. from poudriere:

Little helper gimmicks like this should not had been committed in the first
place, just as they do not belong to an individual port's Makefile.  Factor
them out in Mk/* somewhere, so it won't pollute your ports and very unlucky
to be committed by accident.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150717063125.GB48401>