Date: Sat, 4 Mar 2017 12:13:28 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: rgrimes@freebsd.org, Ngie Cooper <ngie@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314654 - in head/cddl: lib/drti lib/libavl lib/libctf lib/libdtrace lib/libnvpair lib/libumem lib/libuutil lib/libzfs lib/libzfs_core lib/libzpool sbin/zfs sbin/zpool usr.bin/ctfconver... Message-ID: <a0d4d6f9-58ce-8b2e-65b9-08e147f1b70d@FreeBSD.org> In-Reply-To: <201703041520.v24FK9ne077279@pdx.rh.CN85.dnsmgr.net> References: <201703041520.v24FK9ne077279@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ihov9xFw63k2E5qU2sKmSnDWK5MQqd05A Content-Type: multipart/mixed; boundary="nggwp8opMlslWnoBvLLiSJmhicnkAl1rW"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: rgrimes@freebsd.org, Ngie Cooper <ngie@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <a0d4d6f9-58ce-8b2e-65b9-08e147f1b70d@FreeBSD.org> Subject: Re: svn commit: r314654 - in head/cddl: lib/drti lib/libavl lib/libctf lib/libdtrace lib/libnvpair lib/libumem lib/libuutil lib/libzfs lib/libzfs_core lib/libzpool sbin/zfs sbin/zpool usr.bin/ctfconver... References: <201703041520.v24FK9ne077279@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201703041520.v24FK9ne077279@pdx.rh.CN85.dnsmgr.net> --nggwp8opMlslWnoBvLLiSJmhicnkAl1rW Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/4/2017 7:20 AM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: ngie >> Date: Sat Mar 4 11:30:04 2017 >> New Revision: 314654 >> URL: https://svnweb.freebsd.org/changeset/base/314654 >> >> Log: >> cddl: normalize paths using SRCTOP-relative paths or :H when possibl= e >> =20 >> This simplifies make logic/output >> =20 >> While here, remove bogus CFLAGS which look for headers in cddl/lib/l= ibumem. >> There aren't any source files there (just Makefiles) > Please again, dont intermingle other chnages when doing a tree wide swe= ep. >=20 > IMHO if you write While here, you probably should do that thing in a=20 > seperate commit, unless this is a single thing your touching in a singl= e > commit. >=20 > It is much easier to glue 2 commits togeather than seperate 1 that > changes 2 things. >=20 Agreed. There were also various comment changes in here. This is why git is nice, you can git add -p and stage multiple commits before pushing. git-svn handles this fine. >=20 > It is also still not clear to me that this was adeqautly disccussed as = I > only saw 2 +'s for staying relative and no one +ing to move forward wit= h this. Where is this discussion? The only one I can find is https://reviews.freebsd.org/D9207 which seems to have a consensus of moving to SRCTOP and :H vs '../..'. --=20 Regards, Bryan Drewery --nggwp8opMlslWnoBvLLiSJmhicnkAl1rW-- --Ihov9xFw63k2E5qU2sKmSnDWK5MQqd05A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJYux/pAAoJEDXXcbtuRpfPyzQH/iUvkWdAtldR8PQy2gCAgYVh 3sTDhw0y4eLg7RoGZkorKG1T44RS43nFTkmJ9T46fl45DvHJ1qS7n1YFhlE9luPN EwmTqTps9+Tmlf/0aIxCRZFM3fdurR0vpzaxetLh7qRX7hE/tW+nTfiK8HBW+k6/ YYiQQ9GEBvwu/Pe6o//1IuqC/Ndr9AQJceXGN0nHxnNSluevSEtQN93WmRMIhQVH cVkeOF1i5I/6hs9pKqkhsBHC98SlbwtV/WL10F115R3BmDa96WdwjRfO1vf1XGUJ JOJ3iv6na1td1VRHFhrJahSxCtDMLEC+c2kYgvzMjd/1lE3zS+1WfhdTqfWt36Y= =PMH0 -----END PGP SIGNATURE----- --Ihov9xFw63k2E5qU2sKmSnDWK5MQqd05A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a0d4d6f9-58ce-8b2e-65b9-08e147f1b70d>