Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Apr 1998 12:56:01 +0300 (EEST)
From:      Timo J Rinne <tri@iki.fi>
To:        Max Euston <meuston@jmrodgers.com>
Cc:        freebsd-bugs@FreeBSD.ORG
Subject:   RE: bin/6254: ftp client follows NULL pointer
Message-ID:  <199804100956.MAA13090@pooh.tky.hut.fi>
In-Reply-To: <01BD63C9.148B6D20.meuston@jmrodgers.com>
References:  <01BD63C9.148B6D20.meuston@jmrodgers.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Max Euston writes:
> Are you sure you are running 'ftp' (client) *from* a FreeBSD box :-)?  I 
> have seen this happen when running 'ftp' from another system to connect to 
> 'ftpd' (server) on a FreeBSD box.

Yes.

>>>>>>>>>>>>>>>>>>   C U T   H E R E   >>>>>>>>>>>>>>>>>>
926.pooh:~> uname -a
        FreeBSD pooh.tky.hut.fi 3.0-971225-SNAP FreeBSD 3.0-971225-SNAP #0: Thu Jan  8 19:33:22 EET 1998     tri@pooh.tky.hut.fi:/usr/src/sys/compile/POOH  i386
928.pooh:~> ftp -d 127.1
        Connected to 127.1.
        220 pooh.tky.hut.fi FTP server (Version 6.00) ready.
        Name (127.1:tri): 
# Control-D here----------^
    ---> USER °ΝΏ
        331 Password required for °ΝΏ.
        Password:
# Control-D here--^
    ---> PASS XXXX
        530 Login incorrect.
        ftp: Login failed.
    ---> SYST
        215 UNIX Type: L8 Version: BSD-199506
        Remote system type is UNIX.
        Using binary mode to transfer files.
        ftp> 
# Control-D here--^
    ---> QUIT
        221 Goodbye.
928.pooh:~> 
>>>>>>>>>>>>>>>>>>   C U T   H E R E   >>>>>>>>>>>>>>>>>>
> If this is the case, I don't think that the 'ftpd' server on FreeBSD cou  
> ld/should try to verify the user name (feel free to convince me otherwise 
> :-)).  If other clients ('ftp') send 'USER <garbage>', how would we verify 
> user names with non-ascii character sets (i.e. with high bit set)?  (I am 
> by no means an expert when it comes to non-US character sets).

So, in FreeBSD 3.0 current (972512) and for example NetBSD-1.3 it
forks as above.  I've added some comments to make it more readable.
Should I really read the source?

Ok.  I do it.  Return value of fgets in line 260 of util.c in ftp
client source is not checked. 

Now it should be straightforward!

//Rinne

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199804100956.MAA13090>