Date: Fri, 27 Dec 2019 23:48:25 +0100 From: Tobias Kortkamp <tobik@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, portmgr@freebsd.org Subject: Re: svn commit: r520989 - in head: comms/xastir graphics/GraphicsMagick graphics/aaphoto graphics/dcraw graphics/dcraw-m graphics/devil graphics/devil/files graphics/digikam graphics/exact-image graphi... Message-ID: <20191227224825.GA36655@urd.tobik.me> In-Reply-To: <20191227212655.354pzp4pu7rj6oj7@ivaldir.net> References: <201912271343.xBRDh0iJ096882@repo.freebsd.org> <20191227212501.GH28436@hades.panopticon> <20191227212655.354pzp4pu7rj6oj7@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 27, 2019 at 10:26:55PM +0100, Baptiste Daroussin wrote: > On Sat, Dec 28, 2019 at 12:25:01AM +0300, Dmitry Marakasov wrote: > > * Baptiste Daroussin (bapt@FreeBSD.org) wrote: > >=20 > > > Author: bapt > > > Date: Fri Dec 27 13:43:00 2019 > > > New Revision: 520989 > > > URL: https://svnweb.freebsd.org/changeset/ports/520989 > > >=20 > > > Log: > > > Update jasper to 2.0.16 > > > =20 > > > This is needed to be able to update gegl to latest version. > > > Bump revision of all consumer as the ABI is not 100% backward compa= tible. > > > Provide a patch for graphics/devil to properly build with latest ja= sper. > > > While here add a missing USES=3Dxorg to graphics/devil > > >=20 > > > Modified: head/graphics/devil/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/graphics/devil/Makefile Fri Dec 27 13:31:41 2019 (r520988) > > > +++ head/graphics/devil/Makefile Fri Dec 27 13:43:00 2019 (r520989) > > > @@ -3,7 +3,7 @@ > > > =20 > > > PORTNAME=3D devil > > > PORTVERSION=3D 1.7.8 > > > -PORTREVISION=3D 23 > > > +PORTREVISION=3D 24 > > > PORTEPOCH=3D 1 > > > CATEGORIES=3D graphics > > > MASTER_SITES=3D SF/openil/DevIL/${PORTVERSION} > > > @@ -12,7 +12,7 @@ DISTNAME=3D DevIL-${PORTVERSION} > > > MAINTAINER=3D amdmi3@FreeBSD.org > > > COMMENT=3D Full featured cross-platform image library > > > =20 > > > -USES=3D alias autoreconf gmake libtool localbase pkgconfig > > > +USES=3D alias autoreconf gmake libtool localbase pkgconfig xorg > >=20 > > Was this indended? It breaks the port. > >=20 >=20 > Weird, it passes my poudriere run, but feel free to revert that part $ make -C graphics/devil WITHOUT=3DX11 =3D=3D=3D> devil-1.7.8_24,1 need to specify xorg modules with USE_XORG. *** Error code 1 The addition of USES=3Dxorg is wrong here in the first place. The only reason the framework even asks you to add USES=3Dxorg is because of an unfixed bug in USES=3Dgl [1,2] where it creates empty USE_XORG which trigger the warning in bsd.port.mk because USE_XORG happens to be defined afterwards. Note how there is no direct USE_XORG in graphics/devil itself. Maybe someone from portmgr can take a look and acknowledge [1,2] because I think this bug is confusing and has been in the tree for long enough. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241790 [2] https://lists.freebsd.org/pipermail/svn-ports-head/2019-November/224968= =2Ehtml --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl4GijdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2HCWwf/eT+yniobyoADvVTW+4lN7iElM73qOdejQwUiqTNv4RSWIW9xHhyWxsBG YIh5Kdc6yykACxAaoqVTi+tSgLVncSErVu3rMF2mvX47rVWht3rZZHWjP3oEztN3 +STYS7T1zZPWgEI6BVrq4XFLblaHrr/V1tTWUPjIfbEgt0muKiqIyi0HHqxHHz/6 fr9a6Fyzuvln4YvlRC3KafTjR6vObteLG8cG3KO3aP6Yyhrci0JMpzMqlRTi3lce ThdxK7EeV/Py56n/YkQkyocAvaCG4hY/jxQd+sluJHJOd7zrIkx6JXDXo8GYeJx3 WGjxqF2rw+ggji76GhwIXEQZybEnrA== =tq62 -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191227224825.GA36655>