Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Dec 2017 16:00:00 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Michael Tuexen <tuexen@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r327205 - head/sys/netinet/libalias
Message-ID:  <20171226160000.GB90333@FreeBSD.org>
In-Reply-To: <201712261524.vBQFOggM046909@repo.freebsd.org>
References:  <201712261524.vBQFOggM046909@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 26, 2017 at 03:24:42PM +0000, Michael Tuexen wrote:
> New Revision: 327205
> URL: https://svnweb.freebsd.org/changeset/base/327205
> 
> Log:
>   Fix CID 1008936.

I'm afraid this is a rather bad commit message.  It should have described
what was the problem and how it was approached (fixed).  Listing CID is
part of the metadata; it cannot replace proper commit log.

Also, please do not mix functional and substantial amount of style changes
in a single commit.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171226160000.GB90333>