Date: Fri, 29 Mar 2013 03:00:42 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Felippe de Meirelles Motta <lippe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r315511 - in head/x11-wm: . qtile Message-ID: <20130329030042.GA4976@FreeBSD.org> In-Reply-To: <201303290055.r2T0tIUo075675@svn.freebsd.org> References: <201303290055.r2T0tIUo075675@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 29, 2013 at 12:55:18AM +0000, Felippe de Meirelles Motta wrote: > New Revision: 315511 > URL: http://svnweb.freebsd.org/changeset/ports/315511 > > +COMMENT= A small, flexible, scriptable tiling window manager written in Python We do not start COMMENT text with indefinite article these days, it would be nice if you tell maintainer about it ;-) > +USE_GITHUB= yes > +GH_ACCOUNT= qtile > +GH_COMMIT= dd52b52 > +GH_TAGNAME= v0.5 I've once noticed that Github might not distinguish between vXXX and XXX tagnames; if this is true, GH_TAGNAME assignment could be dropped. > +PORTDOCS= CHANGELOG INSTALL.rst LICENSE README.rst TODO.rst ^^^^^^^ License files should not be installed as part of docs (usually), we have LICENSE framework that this (already defined). > +post-install: > +.if ${PORT_OPTIONS:MDOCS} > + @${MKDIR} ${DOCSDIR} > +. for f in ${PORTDOCS} > + @${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR} > +. endfor > +.endif 1) we do not mute installation commands (muting MKDIR is fine) 2) consider this equivalent, but simplier construction: .if ${PORT_OPTIONS:MDOCS} @${MKDIR} ${DOCSDIR} ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${DOCSDIR} .endif > +WWW: http://qtile.org Missing / at EOL (per PH section 3.2.1). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130329030042.GA4976>