Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 Jul 2010 18:20:49 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r209742 - head/sys/kern
Message-ID:  <201007061820.o66IKnnE047540@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Tue Jul  6 18:20:49 2010
New Revision: 209742
URL: http://svn.freebsd.org/changeset/base/209742

Log:
  In revoke(), verify that VCHR vnode indeed belongs to devfs.
  
  Found and tested by:	pho
  MFC after:	1 week

Modified:
  head/sys/kern/vfs_syscalls.c

Modified: head/sys/kern/vfs_syscalls.c
==============================================================================
--- head/sys/kern/vfs_syscalls.c	Tue Jul  6 18:17:31 2010	(r209741)
+++ head/sys/kern/vfs_syscalls.c	Tue Jul  6 18:20:49 2010	(r209742)
@@ -4215,7 +4215,7 @@ revoke(td, uap)
 	vfslocked = NDHASGIANT(&nd);
 	vp = nd.ni_vp;
 	NDFREE(&nd, NDF_ONLY_PNBUF);
-	if (vp->v_type != VCHR) {
+	if (vp->v_type != VCHR || vp->v_rdev == NULL) {
 		error = EINVAL;
 		goto out;
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007061820.o66IKnnE047540>