Date: Thu, 30 Nov 2000 23:30:37 -0800 From: Alfred Perlstein <alfred@FreeBSD.ORG> To: "Kenneth D. Merry" <ken@kdm.org> Cc: Bosko Milekic <bmilekic@technokratis.com>, Andrew Gallatin <gallatin@cs.duke.edu>, arch@FreeBSD.ORG Subject: Re: zero copy code review Message-ID: <20001130233037.L8051@fw.wintelcom.net> In-Reply-To: <20001201002235.D10772@panzer.kdm.org>; from ken@kdm.org on Fri, Dec 01, 2000 at 12:22:35AM -0700 References: <14886.63486.157224.937225@grasshopper.cs.duke.edu> <Pine.BSF.4.21.0011302159210.79831-100000@jehovah.technokratis.com> <20001201002235.D10772@panzer.kdm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Kenneth D. Merry <ken@kdm.org> [001130 23:22] wrote: > On Thu, Nov 30, 2000 at 22:18:43 -0500, Bosko Milekic wrote: > > On Thu, 30 Nov 2000, Andrew Gallatin wrote: > > > > [...] > > > <... some helpful comments deleted ....> > > > > > > Many of your comments are directly related to -current, I > > > think I'll let Ken address them... > > > > Another one directly related to -CURRENT: > > > > I just noticed that the uipc_jumbo.c stuff does not do any locking. > > Perhaps it would be nice to lock the code sooner or later. I would be > > willing to go over it and do it but, as I said, I am really not going to > > be able to do much until 2 weeks from now. > > It does have spls in the right places, in this case splimp() and splvm(). > Would you just convert those to the proper mutexes, or are we going to go > with per-data-structure mutexes (i.e. a little finer granularity), or...? > (I don't know much about the mutex strategy we're using...) The vm system is likely to be the last thing to be locked down, if your code dips in the vm system you'll have to aquire Giant, possibly several times through your codepath, the performance can drop dramatically for the SMP case. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001130233037.L8051>