Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Feb 2007 17:53:35 GMT
From:      Paolo Pisati <piso@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 114569 for review
Message-ID:  <200702151753.l1FHrZoj041282@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=114569

Change 114569 by piso@piso_newluxor on 2007/02/15 17:52:53

	don't pass down maxpacketsize if we don't use it.

Affected files ...

.. //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_smedia.c#18 edit

Differences ...

==== //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_smedia.c#18 (text+ko) ====

@@ -129,8 +129,7 @@
 #define TFTP_PORT_NUMBER 69
 
 static void
-AliasHandleRtspOut(struct libalias *, pkt_t ptr, struct alias_link *,	
-		  int maxpacketsize);
+AliasHandleRtspOut(struct libalias *, pkt_t ptr, struct alias_link *);
 static int 
 fingerprint(struct libalias *la, struct ip *pip, struct alias_data *ah)
 {
@@ -138,8 +137,7 @@
 	if (ah->dport != NULL && ah->aport != NULL && ah->sport != NULL &&
             ntohs(*ah->dport) == TFTP_PORT_NUMBER)
 		return (0);
-	if (ah->dport == NULL || ah->sport == NULL || ah->lnk == NULL || 
-	    ah->maxpktsize == 0)
+	if (ah->dport == NULL || ah->sport == NULL || ah->lnk == NULL)
 		return (-1);
 	if (ntohs(*ah->dport) == RTSP_CONTROL_PORT_NUMBER_1
 	    || ntohs(*ah->sport) == RTSP_CONTROL_PORT_NUMBER_1
@@ -160,7 +158,7 @@
 			return (-1);
 		FindRtspOut(la, pip->ip_src, pip->ip_dst,
  			    *ah->sport, *ah->aport, IPPROTO_UDP);
-	} else AliasHandleRtspOut(la, ptr, ah->lnk, ah->maxpktsize);
+	} else AliasHandleRtspOut(la, ptr, ah->lnk);
 	return (0);
 }
 
@@ -481,7 +479,7 @@
 }
 
 static void
-AliasHandleRtspOut(struct libalias *la, pkt_t ptr, struct alias_link *lnk, int maxpacketsize)
+AliasHandleRtspOut(struct libalias *la, pkt_t ptr, struct alias_link *lnk)
 {
 	int hlen, tlen, dlen;
 	struct ip *pip;
@@ -492,8 +490,6 @@
 	const char *server_port_str = "server_port";
 	int i, parseOk;
 
-	(void)maxpacketsize;
-
 	PULLUP_TCPHDR(pip, ptr);
 	if (pip == NULL)
 		return;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702151753.l1FHrZoj041282>