Date: Wed, 29 Mar 2000 18:01:31 +0900 From: Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp> To: m.seaman@inpharmatica.co.uk Cc: Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp> Subject: Re: bin/17657: 4.0-RELEASE routed cores with GENERIC kernel Message-ID: <14561.50795.50112.13042Y@rina> In-Reply-To: In your message of "Wed, 29 Mar 2000 09:48:42 %2B0100 (BST)" <200003290848.JAA24808@mailhost.inpharmatica.co.uk> References: <200003290848.JAA24808@mailhost.inpharmatica.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
--Multipart_Wed_Mar_29_18:01:31_2000-1
Content-Type: text/plain; charset=US-ASCII
On Wed, 29 Mar 2000 09:48:42 +0100 (BST),
m.seaman@inpharmatica.co.uk said:
m.seaman> I only noticed this after the fact, but I guess it's reproducible. It
m.seaman> seems that routed will segfault after about 5 minutes. This was a
m.seaman> freshly installed 4.0-RELEASE system with the GENERIC kernel, before
m.seaman> I'd had a chance to finish cvsup'ing to 4.0-STABLE and re-compile the
m.seaman> kernel.
I had been experiencing the same problem. There seems to be a buffer
overflow in routed(8). Could you please apply the following patch and
see how your new routed(8) works? routed(8) in my box is working just
fine for two weeks with this patch.
--Multipart_Wed_Mar_29_18:01:31_2000-1
Content-Type: text/plain; type=patch; charset=US-ASCII
Content-Disposition: attachment; filename="table.c.diff"
Content-Transfer-Encoding: 7bit
--- table.c.org Fri Sep 17 03:50:10 1999
+++ table.c Sat Mar 11 15:03:09 2000
@@ -617,6 +617,7 @@
}
+#define NAME0_LEN 14
static const char *
rtm_type_name(u_char type)
{
@@ -636,12 +637,12 @@
"RTM_DELADDR",
"RTM_IFINFO"
};
- static char name0[10];
+ static char name0[NAME0_LEN];
if (type > sizeof(rtm_types)/sizeof(rtm_types[0])
|| type == 0) {
- sprintf(name0, "RTM type %#x", type);
+ snprintf(name0, NAME0_LEN, "RTM type %#x", type);
return name0;
} else {
return rtm_types[type-1];
--Multipart_Wed_Mar_29_18:01:31_2000-1
Content-Type: text/plain; charset=US-ASCII
--
Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp> <tanimura@FreeBSD.org>
--Multipart_Wed_Mar_29_18:01:31_2000-1--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14561.50795.50112.13042Y>