Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Jun 1998 22:40:18 -0400 (EDT)
From:      robert@cyrus.watson.org
To:        FreeBSD-gnats-submit@FreeBSD.ORG
Subject:   kern/7105: current: src/sys/libkern/qsort.c includes stdio.h
Message-ID:  <199806290240.WAA06756@fledge.watson.org>

next in thread | raw e-mail | index | archive | help

>Number:         7105
>Category:       kern
>Synopsis:       libkern source includes stdio.h (inappropriate include)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 28 19:40:00 PDT 1998
>Last-Modified:
>Originator:     Robert Watson
>Organization:
>Release:        FreeBSD 3.0-CURRENT i386
>Environment:
IBM notebook

	

>Description:

qsort.c includes stdio.h.  This seems inappropriate as it doesn't
(apparently) use anything from it.  Also, shouldn't it be including
sys/libkern.h if it needs access to things like printf?

>How-To-Repeat:

n/a

Discovered the problem when a source tree was out of sync with the 
/usr/include tree.  As a result, one of the typedefs failed in something
included from stdio.  Leading me to question why it was included.

>Fix:
	
Delete the line #include <stdio.h>

>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806290240.WAA06756>