Date: Fri, 1 Jul 2011 11:34:23 +0800 From: Adrian Chadd <adrian@freebsd.org> To: Wesley Shields <wxs@freebsd.org> Cc: freebsd-net@freebsd.org Subject: Re: fwd: kern/157188: [libpcap] [patch] incorporate patch from upstream Message-ID: <BANLkTi=x1NWMJ-qVa1MyicMwzBxXqyoHBg@mail.gmail.com> In-Reply-To: <20110628002556.GA87130@atarininja.org> References: <201105192153.p4JLrvtH004172@red.freebsd.org> <20110521064847.GB23992@lonesome.com> <20110522193007.GA63178@atarininja.org> <20110628002556.GA87130@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I suggest bugging bz@ as much as possible. :) Adrian On 28 June 2011 08:25, Wesley Shields <wxs@freebsd.org> wrote: > I'm still hoping someone who cares about IPv6 is willing to commit this > fix for libpcap in the base before 9.0. Is anyone willing to tackle > this? It's been in the port for a while now, and in upstream for even > longer. > > -- WXS > > On Sun, May 22, 2011 at 03:30:07PM -0400, Wesley Shields wrote: >> I've updated the port to address this. The audit trail for this PR has a >> patch which touches more than just libpcap. I'm curious if anyone on >> this list has comments on it, and if any committer wants to commit it >> (at least the libpcap part, the others appear right to me). >> >> -- WXS >> >> On Sat, May 21, 2011 at 01:48:47AM -0500, Mark Linimon wrote: >> > Apparently affects both the port and src. >> > mcl >> > >> > On Thu, May 19, 2011 at 09:53:57PM +0000, Peter Losher wrote: >> > > >> > > >Number: =A0 =A0 =A0 =A0 157188 >> > > >Category: =A0 =A0 =A0 misc >> > > >Synopsis: =A0 =A0 =A0 libpcap >> > > >Confidential: =A0 no >> > > >Severity: =A0 =A0 =A0 non-critical >> > > >Priority: =A0 =A0 =A0 medium >> > > >Responsible: =A0 =A0freebsd-bugs >> > > >State: =A0 =A0 =A0 =A0 =A0open >> > > >Quarter: >> > > >Keywords: >> > > >Date-Required: >> > > >Class: =A0 =A0 =A0 =A0 =A0sw-bug >> > > >Submitter-Id: =A0 current-users >> > > >Arrival-Date: =A0 Thu May 19 22:00:27 UTC 2011 >> > > >Closed-Date: >> > > >Last-Modified: >> > > >Originator: =A0 =A0 Peter Losher >> > > >Release: =A0 =A0 =A0 =A08.2-RELEASE >> > > >Organization: >> > > Internet Systems Consortium >> > > >Environment: >> > > FreeBSD freebsd8.lab.isc.org 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu= Feb 17 02:41:51 UTC 2011 =A0 =A0 root@mason.cse.buffalo.edu:/usr/obj/usr/s= rc/sys/GENERIC =A0amd64 >> > > >Description: >> > > One of our engineers @ISC discovered that there is a bug in the curr= ently released version of libpcap (in base and in ports) that can be trigge= red when using an "ip6 protochain" filter. =A0It's due to the fairly compli= cated BPF bytecode that libpcap generates for IPv6 header chasing combined = with a sign extension bug when processing JA (jump absolute) opcodes. =A0(J= A is used to go backwards and without sign extension on 64 bit platforms th= e BPF interpreter incorrectly jumps forward... a lot.) >> > > >> > > >How-To-Repeat: >> > > root@freebsd8:~# tcpdump -nr ip6-hopbyhop-icmp.pcap 'ip6 protochain = 58' >> > > reading from file ip6-hopbyhop-icmp.pcap, link-type EN10MB (Ethernet= ) >> > > Segmentation fault: 11 (core dumped) >> > > >> > > >Fix: >> > > There is a fix in the libpcap repository: >> > > >> > > https://github.com/mcr/libpcap/commit/ecdc5c0a7f7591a7cd4aff696e4275= 7c677fbbf7 >> > > >> > > but the tcpdump-workers have been pretty tardy about putting out new= er code, so it sits there stalled. >> > > >> > > With the patch applied, it all works well and you should see somethi= ng like this: >> > > >> > > -=3D- >> > > $ tcpdump -nr ip6-hopbyhop-icmp.pcap 'ip6 protochain 58' >> > > reading from file ip6-hopbyhop-icmp.pcap, link-type EN10MB (Ethernet= ) >> > > 18:43:07.098489 IP6 fe80::208:7dff:feb7:2cca > ff02::1: HBH ICMP6, m= ulticast listener queryv2 =A0[gaddr ::], length 28 >> > > -=3D- >> > > >> > > >Release-Note: >> > > >Audit-Trail: >> > > >Unformatted: >> > > _______________________________________________ >> > > freebsd-bugs@freebsd.org mailing list >> > > http://lists.freebsd.org/mailman/listinfo/freebsd-bugs >> > > To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.o= rg" >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=x1NWMJ-qVa1MyicMwzBxXqyoHBg>