Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Jul 2008 16:56:30 -0700
From:      Andrew Thompson <thompsa@FreeBSD.org>
To:        Pyun YongHyeon <yongari@FreeBSD.org>
Cc:        current@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/age if_age.c if_agereg.h if_agevar.h
Message-ID:  <20080717235630.GL33414@citylink.fud.org.nz>
In-Reply-To: <200805190140.m4J1e0YW001168@repoman.freebsd.org>
References:  <200805190140.m4J1e0YW001168@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 19, 2008 at 01:39:59AM +0000, Pyun YongHyeon wrote:
> yongari     2008-05-19 01:39:59 UTC
> 
>   FreeBSD src repository
> 
>   Added files:
>     sys/dev/age          if_age.c if_agereg.h if_agevar.h 
>   Log:
>   Add age(4), a driver for Attansic/Atheros L1 gigabit ethernet
>   controller.

+static void
+age_phy_reset(struct age_softc *sc)
+{
+
+        /* Reset PHY. */
+        CSR_WRITE_4(sc, AGE_GPHY_CTRL, GPHY_CTRL_RST);
+        pause("agephy", hz / 1000);
+        CSR_WRITE_4(sc, AGE_GPHY_CTRL, GPHY_CTRL_CLR);
+        pause("agephy", hz / 1000);
+}

This will panic if hz < 1000, perhaps a DELAY(1) is better?


Andrew



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080717235630.GL33414>