Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Jul 2001 03:42:33 -0500
From:      Alfred Perlstein <bright@sneakerz.org>
To:        Peter Pentchev <roam@orbitel.bg>
Cc:        arch@FreeBSD.org
Subject:   Re: kern/29131: Current hungs in sysctl -a while booting + patch
Message-ID:  <20010722034233.B49508@sneakerz.org>
In-Reply-To: <20010722110626.A819@ringworld.oblivion.bg>; from roam@orbitel.bg on Sun, Jul 22, 2001 at 11:06:26AM %2B0300
References:  <200107220334.f6M3YRe01219@kan.dnsalias.net> <20010722110626.A819@ringworld.oblivion.bg>

next in thread | previous in thread | raw e-mail | index | archive | help
* Peter Pentchev <roam@orbitel.bg> [010722 03:02] wrote:
> Hi,
> 
> Can anyone envision any side effects from committing the patch
> in this PR?  Seems like a trivial fix for a typo to me..

Shouldn't "magic" constants be put into the sysctl.h header?

> > >Number:         29131
> > >Category:       kern
> > >Synopsis:       Current hungs in sysctl -a while booting + patch
> > 
> > Index: kern_sysctl.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sys/kern/kern_sysctl.c,v
> > retrieving revision 1.110
> > diff -u -u -r1.110 kern_sysctl.c
> > --- kern_sysctl.c	2001/06/22 19:54:38	1.110
> > +++ kern_sysctl.c	2001/07/22 03:04:45
> > @@ -113,7 +113,7 @@
> >  	 * 100 to leave space for pre-assigned oid numbers.
> >  	 */
> >  	if (oidp->oid_number == OID_AUTO) {
> > -		static int newoid = 100;
> > +		static int newoid = 0x100;
> >  
> >  		oidp->oid_number = newoid++;
> >  		if (newoid == 0x7fffffff)

-- 
-Alfred Perlstein [alfred@freebsd.org]
Ok, who wrote this damn function called '??'?
And why do my programs keep crashing in it?

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010722034233.B49508>