Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Feb 2014 16:53:19 +0100
From:      Tijl Coosemans <tijl@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>, Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r342718 - head/audio/libmad
Message-ID:  <20140205165319.06494484@kalimero.tijl.coosemans.org>
In-Reply-To: <3A1E876406193F10101E533D@ogg.in.absolight.net>
References:  <201402051529.s15FTbbV098516@svn.freebsd.org> <0807AAFF65F7176953AA8581@ogg.in.absolight.net> <3A1E876406193F10101E533D@ogg.in.absolight.net>

next in thread | previous in thread | raw e-mail | index | archive | help
--MP_/HkW+1s7Zj8g.H8.LIGE9W4N
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Wed, 05 Feb 2014 16:38:41 +0100 Mathieu Arnold wrote:
> +--On 5 f=E9vrier 2014 16:35:22 +0100 Mathieu Arnold <mat@FreeBSD.org> wr=
ote:
>| +--On 5 f=E9vrier 2014 15:29:37 +0000 Sunpoet Po-Chuan Hsieh
>| <sunpoet@FreeBSD.org> wrote:
>|| Author: sunpoet
>|| Date: Wed Feb  5 15:29:37 2014
>|| New Revision: 342718
>|| URL: http://svnweb.freebsd.org/changeset/ports/342718
>|| QAT: https://qat.redports.org/buildarchive/r342718/
>||=20
>|| Log:
>||   - Use USES=3Dlibtool
>||=20
>|| Modified:
>||   head/audio/libmad/Makefile
>||=20
>|| Modified: head/audio/libmad/Makefile
>|| =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>|| =3D=3D=3D=3D=3D --- head/audio/libmad/Makefile	Wed Feb  5 15:29:04 2014=
	(r342717)
>|| +++ head/audio/libmad/Makefile	Wed Feb  5 15:29:37 2014	(r342718) @@
>|| -15,8 +15,8 @@ SPEED_DESC=3D	Optimize for speed over accu
>|| =20
>||  CONFIGURE_ARGS=3D	--disable-debugging --enable-sso
>||  GNU_CONFIGURE=3D	yes
>|| -USE_AUTOTOOLS=3D	libtool
>||  USE_LDCONFIG=3D	yes
>|| +USES=3D		libtool
>|| =20
>||  SUB_LIST=3D	VERSION=3D${PORTVERSION}
>||  SUB_FILES=3D	mad.pc
>||=20
>|=20
>| I'm quite sure you forgot to update the plist.
>=20
> And quite possibly bump PORTREVISION in the ports that depend on it.

USES=3Dlibtool also decrements the library version in this case which
should be avoided, so you have to patch the port to decrement age until
the library version is the same as before.  I've attached a patch which
does this.

--MP_/HkW+1s7Zj8g.H8.LIGE9W4N
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=libmad.patch

Index: Makefile
===================================================================
--- Makefile	(revision 342724)
+++ Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=	libmad
 PORTVERSION=	0.15.1b
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	audio
 MASTER_SITES=	SF/mad/${PORTNAME}/${PORTVERSION}
 
@@ -26,9 +26,10 @@ SPEED_CONFIGURE_OFF=	--enable-accuracy
 
 post-patch:
 	@${REINPLACE_CMD} -e 's| -fforce-mem||' ${WRKSRC}/configure
+	@${REINPLACE_CMD} -e '/version_age =/s|=.*|=0|' ${WRKSRC}/Makefile.in
 
 post-build:
-	@${STRIP_CMD} ${WRKSRC}/.libs/libmad.so.2
+	@${STRIP_CMD} ${WRKSRC}/.libs/libmad.so.2.0.1
 
 post-install:
 	${INSTALL_DATA} ${WRKDIR}/mad.pc ${STAGEDIR}${PREFIX}/libdata/pkgconfig/
Index: pkg-plist
===================================================================
--- pkg-plist	(revision 342724)
+++ pkg-plist	(working copy)
@@ -3,4 +3,5 @@ lib/libmad.a
 lib/libmad.la
 lib/libmad.so
 lib/libmad.so.2
+lib/libmad.so.2.0.1
 libdata/pkgconfig/mad.pc

--MP_/HkW+1s7Zj8g.H8.LIGE9W4N--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140205165319.06494484>