Date: Sat, 12 Sep 2015 16:51:54 +0200 From: John Marino <freebsd.contact@marino.st> To: Hajimu UMEMOTO <ume@FreeBSD.org>, Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396689 - in head/mail: cyrus-imapd23 cyrus-imapd24 cyrus-imapd25 Message-ID: <55F43C0A.7050307@marino.st> In-Reply-To: <ygey4gbvgp6.wl-ume@FreeBSD.org> References: <201509111758.t8BHwjA5064734@repo.freebsd.org> <ygezj0suf7x.wl-ume@FreeBSD.org> <D8CB01F5D2938F2E37E9593F@atuin.in.mat.cc> <ygey4gbvgp6.wl-ume@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/12/2015 4:46 PM, Hajimu UMEMOTO wrote: > Hi, > >>>>>> On Sat, 12 Sep 2015 12:52:39 +0200 >>>>>> Mathieu Arnold <mat@FreeBSD.org> said: > > mat> | It seems your changes have many reasons. It is hard to inspect > mat> | whether it becomes equivalent to the one I intended. Could you back > mat> | all of your changes out, then separate every change reason and send > mat> | your proposed diffs to me. > > mat> With respect, no. The thing that you wanted, that is, the man pages > mat> definitions in the Makefie are back where they were. All the other changes > mat> are things the framework was already doing and that you were duplicating. > > Then, I'll back them out by myself, sigh. It is hard to inspect > whether it becomes equivalent to the one I intended. You could make > me be disappointed at your effort. > ume, I think this would be an example of bad citizenship. You have no reason to think Matt's commits are wrong. Unless you have some evidence they are, you should assume they are correct. That also gives you lots and lots of time to go through the changes at your pace. I really don't want to see good changes backed out for bad code, which is what it is being described as. Does poudriere pass QA checks or not? If it does, then the port is working as intended, right? John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55F43C0A.7050307>