Date: Mon, 27 Aug 2001 19:38:09 +0300 (EEST) From: Maxim Sobolev <sobomax@FreeBSD.ORG> To: jhb@FreeBSD.ORG (John Baldwin) Cc: sobomax@FreeBSD.ORG (Maxim Sobolev), cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, dima@unixfreak.org ((Dima Dorfman)) Subject: Re: cvs commit: src/sys/dev/md md.c Message-ID: <200108271638.f7RGcCf49796@vega.vega.com> In-Reply-To: <no.id> from "John Baldwin" at Aug 27, 2001 09:26:32 AM
next in thread | previous in thread | raw e-mail | index | archive | help
> > > On 27-Aug-01 Maxim Sobolev wrote: > >> > >> > >> On 27-Aug-01 Dima Dorfman wrote: > >> > Maxim Sobolev <sobomax@FreeBSD.org> wrote: > >> >> sobomax 2001/08/27 06:25:48 PDT > >> >> > >> >> Modified files: > >> >> sys/dev/md md.c > >> >> Log: > >> >> - On module unload try to detach all configured disks and let unload > >> >> proceed > >> >> if all disks were detached sucessfully; > >> > > >> > I'm not sure this is wise. More likely than not, trying to unload md > >> > while there are still disks attached is a mistake on the user's part, > >> > especially considering that most people aren't going to be loading and > >> > unloading it on a regular basis. I understand why this may be useful > >> > for a developer working on md, but it seems counter-intuitive from a > >> > regular user's perspective. > >> > >> Yeah, I'd rather get an error (You're still using this stupid! *bonk*) like > >> EBUSY or some such rather than have it do magical things for me behind my > >> back. > > > > Folks, have you tried to look into patches in question before commenting > > on them (no pun intended)? As I said the driver will try to detach *idle* > > disks only (i.e. configured but not opened), so they aren't really "in > > use". > > Erm, you said "all configured disks". This does not clearly say "all configured > but not opened disks". An opened disk is obviously configured, so it easily > fits in the set of all configured disks. However, with the extra explanation, > it now seems ok. Plese forgeve me my pur Englesh skeels... ;) -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200108271638.f7RGcCf49796>