Date: Wed, 25 Oct 1995 15:59:15 +0800 (WST) From: Peter Wemm <peter@jhome.DIALix.COM> To: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= <ache@astral.msk.su> Cc: ports@freebsd.org Subject: Re: urgent bugfix for "screen". Message-ID: <Pine.BSF.3.91.951025155716.19259D-100000@jhome.DIALix.COM> In-Reply-To: <co-ITZmiH1@ache.dialup.demos.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 25 Oct 1995, =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= wrote: > In message <Pine.BSF.3.91.951025121529.19259A-100000@jhome.DIALix.COM> > Peter Wemm writes: > > >#ifdef PASSWORD > >#include <pwd.h> /* for _PASSWORD_LEN */ > >#endif > >#include "config.h" > >.... > >#ifndef _PASSWORD_LEN > >#define _PASSWORD_LEN 30 > >#endif > >char Password[_PASSWORD_LEN]; > > >This is wrong on two counts.. All the MD5 passwords I've seen were > >LONGER than 30 characters (34 or 35 I think), and config.h is where > >"PASSWORD" is defined! - meaning that the system <pwd.h> include file is > >never #included (the system _PASSWORD_LEN is 128 BTW) because "PASSWORD" > >is not defined yet. > > You need to switch two lines instead, i.e. > > #include "config.h" > #ifdef PASSWORD > #include <pwd.h> /* for _PASSWORD_LEN */ > #endif > > it is better way. I know.. that's what I sent in. I was commenting on the original file which was backwards, and appended my replacement patch-ac file onto the end of the message, because a diff of a diff is nearly impossible to read... -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.91.951025155716.19259D-100000>