Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Dec 2013 22:56:50 +0000 (UTC)
From:      John Marino <marino@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r337822 - head/math/parmetis
Message-ID:  <201312272256.rBRMuojP063283@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marino
Date: Fri Dec 27 22:56:50 2013
New Revision: 337822
URL: http://svnweb.freebsd.org/changeset/ports/337822

Log:
  math/parmetis: Unbreak on FreeBSD 10+
  
  ParMetis requires both cmake and gmake.  Apparently gmake sets ${MAKE}
  to value of "make" if undefined, and this causes the bmake to be launched
  for subdirectories rather than gmake.  That's the cause of the build
  failure for FreeBSD 10+.  The eventual fix using MAKE_ARGS took me hours
  to figure out, this drove me crazy!
  
  Fix covered by portmgr general blanket for ports modernization (bmake).

Modified:
  head/math/parmetis/Makefile

Modified: head/math/parmetis/Makefile
==============================================================================
--- head/math/parmetis/Makefile	Fri Dec 27 22:39:23 2013	(r337821)
+++ head/math/parmetis/Makefile	Fri Dec 27 22:56:50 2013	(r337822)
@@ -10,7 +10,7 @@ MASTER_SITE_SUBDIR=	. OLD
 DISTNAME=	${PORTNAME:L}-${PORTVERSION}
 
 MAINTAINER=	bf@FreeBSD.org
-COMMENT=	A package for parallel (mpi) unstructured graph partitioning
+COMMENT=	Package for parallel (mpi) unstructured graph partitioning
 
 LICENSE=	METIS
 LICENSE_NAME=	University of Minnesota METIS License
@@ -20,9 +20,9 @@ LICENSE_PERMS=	auto-accept
 OPTIONS_DEFINE=	OPENMPI DOCS
 OPENMPI_DESC=	Use openmpi instead of mpich2
 
-USES=		cmake
-USE_GMAKE=	yes
+USES=		cmake gmake
 
+MAKE_ARGS+=	MAKEFLAGS=MAKE=${GMAKE}
 PORTDOCS=	manual.pdf
 PLIST_FILES=	include/parmetis/parmetis.h \
 		lib/parmetis/libmetis.a lib/parmetis/libparmetis.a
@@ -44,12 +44,12 @@ MPICC=		${LOCALBASE}/bin/mpicc
 post-patch:
 	@${REINPLACE_CMD} -e \
 		's|BUILDDIR =.*|BUILDDIR = build| ; \
-		 s|make -C|$$(MAKE) -C|' ${WRKSRC}/Makefile
+		 s|make -C|${MAKE_CMD} -C|' ${WRKSRC}/Makefile
 	@${REINPLACE_CMD} -e \
 		's|"-O3"|""|' ${WRKSRC}/metis/GKlib/GKlibSystem.cmake
 
 do-configure:
-	@cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${GMAKE} ${MAKE_FLAGS} \
+	@cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD} ${MAKE_FLAGS} \
 		${MAKEFILE} config prefix="${PREFIX}" cc="${MPICC}"
 
 do-install:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312272256.rBRMuojP063283>