Date: Fri, 18 Oct 2013 10:10:19 +0200 From: John Marino <freebsd.contact@marino.st> To: Oliver Lehmann <oliver@freebsd.org> Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r330725 - in head/games/heretic: . files Message-ID: <5260ECEB.70302@marino.st> In-Reply-To: <20131018095930.Horde.738PZNGCU9PTyyjPK3vb3g1@avocado.salatschuessel.net> References: <201310180705.r9I75eZV063407@svn.freebsd.org> <20131018075408.GI42657@ithaqua.etoilebsd.net> <20131018095930.Horde.738PZNGCU9PTyyjPK3vb3g1@avocado.salatschuessel.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/18/2013 09:59, Oliver Lehmann wrote:
>
> Baptiste Daroussin <bapt@freebsd.org> wrote:
>
>> On Fri, Oct 18, 2013 at 07:05:40AM +0000, Oliver Lehmann wrote:
>
>>> [...]
>>> +-CC = gcc
>>> ++#CC = gcc
>>> [...]
>
>>
>> Passing CC and CFLAGS to MAKE_ARGS will achieve the same goal without
>> the need
>> of an external patch.
>>
>> MAKE_ARGS= CC="${CC}" CFLAGS="${CFLAGS}"
>
> Please reread my patch - I snipped it to the important part. ;)
>
Oliver,
As I understand it, the original line only defines CC to "gcc" if CC is
not present in the MAKE_ARGS. Thus bapt is correct, you don't need to
patch this line.
(In BSD make, it would be CC?=gcc, but gmake looks at MAKE_ARGS)
John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5260ECEB.70302>