Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 May 2004 09:41:55 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        Andre Oppermann <andre@freebsd.org>
Cc:        cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/net if_vlan.c
Message-ID:  <20040504093938.U28384@root.org>
In-Reply-To: <40975C30.5D247B83@freebsd.org>
References:  <200405040239.i442dfL0011742@repoman.freebsd.org> <40970329.3070507@freebsd.org> <40975C30.5D247B83@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 May 2004, Andre Oppermann wrote:
> Scott Long wrote:
> >
> > Scott Long wrote:
> >
> > > scottl      2004/05/03 19:39:41 PDT
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/net              if_vlan.c
> > >   Log:
> > >   Add route.h to pick up the rt_ifmsg() declaration.
> > >
> > >   Revision  Changes    Path
> > >   1.60      +1 -0      src/sys/net/if_vlan.c
> >
> > Not to pick on anyone in particular, but we've had about three days in a
> > row now with tinderbox failures.  Please, everyone, step back and be
> > more careful.  Thanks,
>
> Scott, I'm sorry for that.
>
> However it worked for me just fine.  The reason I just found out is that
> I wasn't compiling if_vlan into the kernel but loaded and tested it as
> module.  Compiling it as module doesn't give any compiler warning and
> works w/o a hitch.  Dunno why?

Because -Werror doesn't get turned on for module builds nor are proper .h
files generated, leading to things like _mtx_lock_flags being undefined
when WITNESS is used for the kernel compile.  Why is this?  Because every
time someone tries to fix it, people protest.

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040504093938.U28384>